Repository navigation
Fix Windows FIPS upgrade failure caused by mismatched directory name - #16065
Merged
Merged
Conversation
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
lorienhu
force-pushed
the
lhu-windows-fips-unpack
branch
from
August 7, 2026 00:34
057deb6 to
4284297
Compare
lorienhu
force-pushed
the
lhu-windows-fips-unpack
branch
from
August 7, 2026 00:35
4284297 to
01587c1
Compare
This comment has been minimized.
This comment has been minimized.
ycombinator
enabled auto-merge (squash)
August 7, 2026 15:48
ycombinator
disabled auto-merge
August 7, 2026 15:48
ycombinator
reviewed
Aug 7, 2026
ycombinator
previously approved these changes
Aug 7, 2026
ycombinator
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this.
💚 Build Succeeded
cc @lorienhu |
ycombinator
approved these changes
Aug 7, 2026
Contributor
|
@Mergifyio backport 9.5 9.4 8.19 |
Contributor
✅ Backports have been createdDetails
|
This was referenced Aug 7, 2026
Merged
Merged
lorienhu
added a commit
that referenced
this pull request
Aug 7, 2026
lorienhu
added a commit
that referenced
this pull request
Aug 8, 2026
lorienhu
added a commit
that referenced
this pull request
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Strip 'fips' from filename prefix for .zip in the upgrade unpack step, matching the naming for .tar.gz archives.
Why is it important?
Windows FIPS upgrades failed due to a mismatch between the directory name computed from the zip filename and the actual directory name inside the archive.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testUpgrade integration tests for Windows FIPS should be enabled in separate PR for tracking.Disruptive User Impact
N/A
How to test this PR locally
go test ./internal/pkg/agent/application/upgrade/... -run TestGetFileNamePrefix -vRelated issues
.elastic-agent.active.commitis missing. #16050