Repository navigation
Add version metadata to version command - #4820
Merged
michel-laterman merged 2 commits intoApr 24, 2025
Merged
Conversation
Add build commit, build time, and FIPS distribution indicator to the output of the version command. Add FIPS distribution indicator to initial log line.
michel-laterman
requested review from
cmacknz,
kruskall,
pchila and
ycombinator
April 16, 2025 19:38
|
ycombinator
reviewed
Apr 18, 2025
ycombinator
approved these changes
Apr 24, 2025
mergify Bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Add build commit, build time, and FIPS distribution indicator to the output of the version command. Add FIPS distribution indicator to initial log line. (cherry picked from commit b7ea9a2)
2 tasks done
michel-laterman
added a commit
that referenced
this pull request
Apr 28, 2025
Add build commit, build time, and FIPS distribution indicator to the output of the version command. Add FIPS distribution indicator to initial log line. (cherry picked from commit b7ea9a2) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
We are not able to determine if a fleet-server binary is a FIPS distribution or not.
How does this PR solve the problem?
Add build commit, build time, and FIPS distribution indicator to the output of the version command. Add FIPS distribution indicator to initial log line.
How to test this PR locally
Run:
./fleet-server -vExample output:
Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog tool