Repository navigation
[8.18](backport #5372) Restore connection-level limiter - #5376
Merged
Merged
Conversation
Restore connection level limiter to prevent OOM incidents. (removed in #4402) This limiter is used in addition to the request-level throttle so that once our in-flight requests reaches max_connections a 429 is returned, but if the total connections the server uses is over max_connections*1.1 the server drops the connection before the TLS handshake. (cherry picked from commit 39199ef) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # internal/pkg/api/server.go
Contributor
Author
|
Cherry-pick of 39199ef has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
6 tasks done
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
added 2 commits
August 29, 2025 15:51
michel-laterman
approved these changes
Aug 29, 2025
michel-laterman
enabled auto-merge (squash)
August 29, 2025 23:21
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏 |
Contributor
|
buildkite test this |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Use of only the throttle middleware can result in OOM incidents under high load.
How does this PR solve the problem?
Restore connection level limiter to prevent OOM incidents. (removed in #4402)
This limiter is used in addition to the request-level throttle so that once
our in-flight requests reaches max_connections a 429 is returned, but if the
total connections the server uses is over max_connections*1.1 the server drops
the connection before the TLS handshake.
Design Checklist
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolThis is an automatic backport of pull request Restore connection-level limiter #5372 done by Mergify.