Repository navigation
Don't index so many saved object fields #43673
Description
Activity
- addedTeam:CorePlatform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//
on Aug 21, 2019 Pinging @elastic/kibana-platform
If we switch from
keywordtoobject(which I hope) it would be great if we could introduce this as optional in the 7.x releases. The saved objects could contain a fielddecoded: trueto indicate in the 7.x cycle if KB has to encode it or not. It would be off by default. In 8.0 the default would then be true. This would help with the migration, allowing the assets of the last minors of the 7.x releases assuming they havedecoded: trueinside, also to be compatible with 8.x.- added 2 commits that reference this issue
on Nov 20, 2019 @elastic/kibana-platform Any update on this? We are using decoded JSON in all our packages (elastic/package-registry#354) at the moment for versioning purposes but then encode them again during the packaging. It would be nice to align here if possible.
This would help with the migration, allowing the assets of the last minors of the 7.x releases assuming they have decoded: true inside, also to be compatible with 8.x.
Kibana migrations already take care of backwards compatibility. So in 8.0 the maps team could write a migration to store
layerlistJSONas a decoded object. If a user imports a 7.last map or a 7.last map is sent to the saved objects HTTP API, these objects will automatically be migrated (decoded) before being stored.This doesn't solve for the unnecessary encoding/decoding you currently have in package-registry (at least not until 8.0), but I assume the pain isn't bad enough to justify adding a JSON encoding/decoding option to saved objects just to remove this serialization?
My question is more about long term alignment. Is the plan in 8.0 to have all SO content decoded or will it stay as is today?
Yes, all JSON strings should be stored decoded as objects in 8.x. This will ultimately be up to different teams to implement and I'm not sure if we could enforce this for 8.0 but the effort should be minimal so I don't see a reason teams wouldn't be able to comply.
This is great! I'm wondering if the "owners" of each saved object know about this? If not, perhaps worth sending out a note or ping them here?
Yes I agree, it's definitely worth coordinating this with all the teams. However, since 8.x is still a long way off I think teams would benefit by not having 7.x and master branches diverge until we're closer to 8.x. I will own giving teams an early heads up during 8.0-alpha1
Reacted by Nicolas Ruflin27 remaining items
- added a commit that references this issue
on Jul 9, 2020 After assessing we've come to the conclusion that throughout out Alerting and Actions there are actually only two fields we can remove, as they're binary and not searchable anyway.
With that in mind - we might leave it as is, as omitting these fields from the mappings could cause confusion in maintenance further down the line.Makes sense 👍 Especially for 7.9 we need to focus on the low hanging fruit.
I made the
flattenedsection a bit more detailed to explain, when thedynamic: falseapproach is more preferable, since I think there are not that much cases whereflattenedwould actually be the preferred way.Reacted by Rudolf Meijeringstriked out a few plugins that are deprecated.
Reacted by AlexFClosing this as the enhancements we've made to scale saved object migrations #144035 and serverless zdt migrations prevent us from removing existing fields. To mitigate the field growth we have split the .kibana saved objects into several smaller indices.
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone (7.13)
Update 29 June 2020
With 7.9 currently having ~960 fields we're fast approaching the 1000 field default limit. Please audit your plugins mappings and remove any unnecessary fields. Link from your PR back to this issue and mark your plugin's task as complete once the PR has been merged.
Removing fields
Setting
index:falseanddoc_values:falseremoves some of the overhead of a field, but doesn't reduce the field count. To reduce the field count fields need to be removed from the mappings completely. This can be done by specifyingdynamic: falseon any level of your mappings.For example, the following diff will remove three fields from the field count. The removed fields can still be stored in the Saved Object type but searching and aggregation is only possible on the
timestampfield. Note: this change also removes any validation on Elasticsearch, which will allow saved objects with unknown attributes to be saved. Because of this we recommend by starting only with low-risk saved object types like telemetry data.You can use the following command to count the amount of fields to do a before/after comparison (requires
brew install jq):Plugins:
[ ] plugins/timelion @elastic/kibana-app @flash1293xpack/plugins/canvas @elastic/kibana-canvasxpack/plugins/file_upload @elastic/kibana-gisxpack/plugins/graph @elastic/kibana-app @flash1293xpack/plugins/task_manager @elastic/kibana-alerting-servicesTask Manager does not use the .kibana indexOriginal issue
Looking at the current mapping for a lot of our saved objects we're indexing a terrible amount of unnecessary fields, i.e. fields we know we'll never want to search through or filter over. Indexing those will just waste some more heap in Elasticsearch, if the field is unnecessary analyzed waste a couple of milliseconds on every insert and thus every migration. We even use a lot of
textfields in places where we store stringified JSON which doesn't make any sense, since the analyzer won't end up with anything meaningful here.This is not a huge problem, since the.kibanaindex is rather small usually, and also a lot of those JSON fields might be over the defaultignore_abovevalue of 256 and thus not indexed in most documents. Despite not being a huge problem I discussed this with @joshdover @tylersmalley and @rudolf and we agreed, that we should not waste Heap and indexing performance on fields we know we'll never need indexed.As the field count on
.kibanais approaching the default limit of 1000 fields we need to urgently evaluate whether or not all fields are really necessary for performing queries or filters.Mapping recommendations
Here are a couple of general recommendations for how the mappings of a saved object should look:
type=text only for full text search on real text
A field with type
textin the mapping will be analyzed and indexed. This makes sense only for fields we know we want to do full text search on, e.g. thetitleordescriptionof a field. If you don't need the field value analyzed for full text search, don't index the field (see below) or usekeywordwith an appropriateignore_aboveas a type instead. Good examples for a properkeywordfield would be thevisTypeorlanguageof a query.Don't index if not needed
Especially with
keywordfields, we very often index a field without thinking about it (because it's the default option). If we know we'll never need to aggregate over that field or query for that field, but just have it available when retrieving the saved object, setindex: falseanddoc_values: false(unless it's atextorannotated_textfield) in the mapping for that field.A couple of examples where it might make sense to have a (
keyword) field indexed:visType: we might want to filter on that later and thus need to be able to query by that fieldlanguage(of a query): even though we might never want to expose that in the UI, we might want to aggregate that field for telemetry dataA couple of examples where indexing doesn't make much sense:
expression(the "canvas" expression of a visualization): It doesn't make any sense filtering on the complex expression as a whole, neither aggregate over it. If we would want to build telemetry, we would anyway need to look at each document individually and e.g. parse it and count the containing functions.JSON fields
We have a couple of places where we use a
keywordfield (often even indexed) to store some JSON object, like the configuration of a visualization, or the state of a dashboard. As a first step, these fields should be set toindex: false.As a further optimization this data can be saved as a field of type
objectwithenabled: false. That way the content of that field will simply be ignored by Elasticsearch, it won't be indexed or analyzed, but still returned as it was indexed (as JSON) in the saved object. This removes an unnecessaryJSON.stringifyandJSON.parsewhen saving/loading those objects. Note: this will require writing a migration function for your saved object and changing any consuming code, so this is not an immediate need, but rather something to work towards for 8.0.Consider using
type: 'flattened'(licence basic) if you need to search over many fields or an unknown amount of fieldsFlattened types uses a single field for the entire object. It comes with some limitations but in many instances can significantly reduce the field count while still being able to search/aggregate over the fields inside the object.
Keep in mind, that using the
flattenedfield type, will still index all data within this field. If you just need one specific sub-field aggregated/searchable, but the rest not, the above describeddynamic: falseapproach (where the parent key isdynamic: falseand just that one sub-field you need search/aggregation on would have an (indexed) typing) would be more preferable. Usage offlattenedis mostly preferred, if you potentially need to search/aggregate through a larger amount of sub-fields.What happens after I changed my plugins mappings?
If you switch a field from an indexed to a not-indexed state (e.g. with
enabled: falseorindex: false), the migration system will automatically update the mappings when Kibana is upgraded, no further action is required. If your plugin has recently removed or renamed an entire Saved Object type, these old mappings might not have been cleaned up. Please reach out to @elastic/kibana-platform if you think this might be the case.