Skip to content

[ML] Removes APM NodeJS and RUM Javascript modules - #119945

Merged
peteharverson merged 3 commits into
elastic:mainfrom
peteharverson:ml-delete-apm-nodejs-jsbase-modules
Dec 1, 2021
Merged

peteharverson merged 3 commits into
elastic:mainfrom
peteharverson:ml-delete-apm-nodejs-jsbase-modules

Conversation

@peteharverson

@peteharverson peteharverson commented Nov 30, 2021 •

Copy link
Copy Markdown
Contributor

Summary

Removes the APM NodeJS and RUM Javascript anomaly detection job modules.

APM jobs for apm_jsbase and apm_nodejs were added in 7.6. These were added as ML modules which could be created from the ML UI if data existed where agent.name was either js-base or nodejs. However these two APM modules do not have a future purpose and so are being removed for 8.0.

These APM jobs could not be created or viewed from the APM UI. Jobs could only be created or viewed from the ML UI.

Checklist

@peteharverson peteharverson added review :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 30, 2021
@peteharverson peteharverson self-assigned this Nov 30, 2021
@peteharverson
peteharverson requested a review from a team as a code owner November 30, 2021 11:43
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci

Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@peteharverson peteharverson added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 30, 2021

@pheyos pheyos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 1, 2021
@peteharverson
peteharverson merged commit c47899f into elastic:main Dec 1, 2021
@peteharverson
peteharverson deleted the ml-delete-apm-nodejs-jsbase-modules branch December 1, 2021 11:51
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 1, 2021
* [ML] Removes APM NodeJS and RUM Javascript modules

* [ML] Delete unnecessary module_apm archive

* [ML] Fix get_module API test
@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 1, 2021
* [ML] Removes APM NodeJS and RUM Javascript modules

* [ML] Delete unnecessary module_apm archive

* [ML] Fix get_module API test

Co-authored-by: Pete Harverson <pete@elastic.co>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
* [ML] Removes APM NodeJS and RUM Javascript modules

* [ML] Delete unnecessary module_apm archive

* [ML] Fix get_module API test
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* [ML] Removes APM NodeJS and RUM Javascript modules

* [ML] Delete unnecessary module_apm archive

* [ML] Fix get_module API test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:breaking review v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants