Skip to content

Fix stats permissions and use underscore instead of dash - #12478

Merged
stacey-gammon merged 1 commit into
elastic:masterfrom
stacey-gammon:fix/stats-api-permissions
Jun 26, 2017
Merged

stacey-gammon merged 1 commit into
elastic:masterfrom
stacey-gammon:fix/stats-api-permissions

Conversation

@stacey-gammon

Copy link
Copy Markdown
  • Uses callWithRequest instead of callWithInternalUser
  • Changes dashes to underscores.

Fixes #12436

cc @epixa

@stacey-gammon

Copy link
Copy Markdown
Author

jenkins, test this

@pickypg pickypg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@tsullivan tsullivan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for picking up the snake case issue

@stacey-gammon
stacey-gammon merged commit 929015b into elastic:master Jun 26, 2017
@epixa

epixa commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

Awesome! Thanks for the quick turnaround on this

@jimgoodwin jimgoodwin added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:fix labels Jul 25, 2017
@stacey-gammon
stacey-gammon deleted the fix/stats-api-permissions branch October 24, 2017 13:55
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants