Repository navigation
allows to order percentiles freely - #12498
Merged
Merged
Conversation
thomasneirynck
approved these changes
Jun 27, 2017
weltenwort
self-requested a review
June 27, 2017 09:42
weltenwort
reviewed
Jun 27, 2017
| self.getUnitName = _.partial($parse($attrs.unit), $scope); | ||
|
|
||
| const defaultRange = self.range = parseRange('[0,Infinity)'); | ||
| self.validateOrder = $attrs.validateOrder ? $parse($attrs.validateOrder)($scope) : true; |
Member
There was a problem hiding this comment.
What is the advantage over just using scope: { validateOrder: '=?' }? That way no extra $parse is required and the attribute's presence is easily visible to a consumer of the directive.
| ng-model="agg.params.percents" | ||
| unit-name="percent" | ||
| range="[0,100]" | ||
| validate-order="false" |
Member
There was a problem hiding this comment.
How about representing more of the semantics in the name, e.g. validate-ascending-order? Or we could make it more flexible by allowing different orderings as in validate-order="asc|desc".
weltenwort
approved these changes
Jun 27, 2017
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12497