Repository navigation
[Discover] Enable document explorer as default - #125485
Conversation
|
@elasticmachine merge upstream |
| defaultMessage: 'Document Explorer or classic view', | ||
| }), | ||
| value: true, | ||
| value: false, |
There was a problem hiding this comment.
So, this is the actual change :), all the rest is about fixing confused functionals
| await kibanaServer.uiSettings.update({ | ||
| 'context:defaultSize': `${TEST_DEFAULT_CONTEXT_SIZE}`, | ||
| 'context:step': `${TEST_STEP_SIZE}`, | ||
| 'doc_table:legacy': true, |
There was a problem hiding this comment.
Note there are cases we need to clean up later on, think it's fine, since it's not the doc table that's being tested in these cases
There was a problem hiding this comment.
Maybe add an issue to track cleanup of these tests later on?
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
ThomThomson
left a comment
There was a problem hiding this comment.
Dashboard functional test changes LGTM. Just left one small question!
| .toArray() | ||
| .map((mark) => $(mark).text()); | ||
| expect(marks.length).to.above(10); | ||
| expect(marks.length).to.above(0); |
There was a problem hiding this comment.
Just out of curiosity, what causes the difference here? Has the highlighting functionality changed?
There was a problem hiding this comment.
Well, the Document explorer uses virtualization to display just the docs that are visible to the user, not rendering others. So when using document explorer, the expected number is 6. I didn't change it to this number, because I implemented it in a way that it also would work if we decide to step back (because this feature already has a history, of putting it off again).
The test works now for classic and document explorer, and I think not the number of found highlighted terms is relevant, but that there are highlighted terms rendered. Which proves: highlighting works. And if we ever decide to migrate classic table -> document explorer -> 🍪 ... it should also work
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…c#125485) * Enable document explorer in Discover as default document table * Fix lots of functional tests
Summary
This PR enables the new Document explorer as the default data table in Discover 🥳 . So it's no longer necessary to go to
Advanced settings.Most of the changes in this PR are fixes for functional tests failing because of this change.
Checklist