Repository navigation
Default query to match_all instead of query_string - #12583
lukasolson wants to merge 2 commits into
Conversation
|
@lukasolson want me to just cherry-pick this into my new PR so we don't have to remember to merge it after the fact? |
Yeah, that'd be great. |
weltenwort
left a comment
There was a problem hiding this comment.
if still relevant after the latest cherry-picking
| @@ -0,0 +1 @@ | |||
| export const matchAll = { match_all: {} }; | |||
There was a problem hiding this comment.
I wonder if this is worth putting into a separate file if it only has one use.
There was a problem hiding this comment.
I agree, probably not really necessary. I'll make the change in my PR.
|
@lukasolson @Bargs did this get merged? It looks like it was closed and I was wondering if #12097 can be considered resolved |
|
@dakrone It got pulled into another PR which is still open. |
|
@lukasolson oh cool, is it #12624 ? |
|
Yup, that's the one |
Depends on #11915.
Fixes #12097.
This PR simply updates the default query (when someone has entered nothing into the query bar) to
{"match_all": {}}instead of{"query_string": {"query": "*"}}. This has major impacts on performance in certain cases, especially when there are a large number of fields and there is nodefault_fieldset.(To see the subset of changes related to this PR, look at the most recent commit.)