Skip to content

#12656 Fixes Aria-Hidden without value - #12658

Merged
timroes merged 1 commit into
elastic:masterfrom
varunsharma27:origin/ariahidden
Jul 6, 2017
Merged

timroes merged 1 commit into
elastic:masterfrom
varunsharma27:origin/ariahidden

Conversation

@varunsharma27

Copy link
Copy Markdown
Contributor

These are all no-valued ariahidden attributes i could find.

@elasticmachine

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@timroes
timroes self-requested a review July 5, 2017 08:19
@timroes

timroes commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

Jenkins, test this

@timroes timroes added Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. bug Fixes for quality problems that affect the customer experience labels Jul 5, 2017
@timroes
timroes merged commit 411593c into elastic:master Jul 6, 2017
@cjcenizal

Copy link
Copy Markdown
Contributor

Thanks for doing this @varundbest !

@cjcenizal

Copy link
Copy Markdown
Contributor

@timroes Could you update this PR with the versions it's going into? And could you backport it, if necessary?

@epixa

epixa commented Oct 11, 2017

Copy link
Copy Markdown
Contributor

@timroes Did you ever backport this?

@timroes

timroes commented Oct 12, 2017 •

Copy link
Copy Markdown
Contributor

@epixa This was merged before we branched the 6.0 and 6.x branches away, and according to git this is in both branches:

$ git branch --contains 411593c                                                                                                                                                    
  6.0
* 6.x

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0-rc1 v6.0.0 v6.1.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants