Repository navigation
fixing refresh and auto refresh - #12752
Conversation
There was a problem hiding this comment.
Works well, except clicking the magnifying glass next to the query-bar does not refresh the data.
In hindsight, I'm not sure if the should refresh the data to begin with. It would mean we have two buttons (search and refresh) that do exactly the same.
I'm not sure if the search-button from the query-bar should govern the entire page, as it's not related to the time-picker or the filter-bar.
|
i agree, that magnifying glass should only submit a query right ? |
|
@ppisljar In the Also, I think maps_visualization could benefit from this PR. Before the vis refactor, This will help me with Filter geohash_grid aggregation to map view box with collar. I need to trigger a fetch when the map view box is outside of the map collar and having to do this via saving the state is a little more difficult |
|
@nreese visualization should never directly trigger a reload ... doing vis.emit('reload') does the same as doing the vis.updateState() ... it just notifies that it should do something .... |
|
uiState now triggers normal reload path (calling scope.fetch()) .... |
|
jenkins, test this |
| $scope.fetch(); | ||
| }; | ||
| $scope.vis.on('reload', reload); | ||
| $scope.$on('courier:searchRefresh', reload); |
There was a problem hiding this comment.
pressing the magnifier on the dashboard doesn't work. Consider adding
$scope.vis.on('reload', reload);
$scope.$on('courier:searchRefresh', reload);
$scope.$on('fetch', () => {
console.log('fetching on command from dashboard.js');
$scope.vis.forceReload();
});
|
apart from dashboard issue, LGTM. |
This was introduced as part of elastic#12752, but needs more review to verify if this is right way forward.
This was introduced as part of #12752, but needs more review to verify if this is right way forward.
This reverts commit 574f5ca. This needs more review.
|
@ppisljar Please add a Release Note: paragraph to the description that describes what changed please |
|
Removing release_note:fix label. This fixed a regression introduced by the refactor in master, but should not affect any user of v5. So I think we can skip the release note here. |
* fixing refresh and auto refresh * cleaning up state monitor * uiState should trigger normal reload path * query bar search should force refresh * reload on global fetch event
This was introduced as part of elastic#12752, but needs more review to verify if this is right way forward.
…2799) This reverts commit 36e1673. This needs some more review, as in-tandem with the refresh PR, elastic#12752, it may introduce some unwanted side-effects.
closes #12733
closes #12781