Repository navigation
Add breadcrumb-page-title to management-app - #12765
Merged
Merged
Conversation
w33ble
reviewed
Jul 11, 2017
| sectionName: '@section', | ||
| omitPages: '@omitBreadcrumbPages' | ||
| omitPages: '@omitBreadcrumbPages', | ||
| breadcrumbPageTitle: '=' |
Contributor
There was a problem hiding this comment.
I'd probably just call this page-title, since the consumer shouldn't care where the title is used, and we could move that title out of the breadcrumb in the future.
w33ble
approved these changes
Jul 11, 2017
w33ble
left a comment
Contributor
There was a problem hiding this comment.
One small comment, but this LGTM
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Adds breadcrumb-page-title to management-app * Changes argument name to page-title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The
bread-crumbscomponent allows for the consumer to pass in apage-titlevalue which is appended as the final breadcrumb in the chain. This PR adds a scope argument to themanagement-appto take advantage of it.Changes: Adds a
breadcrumbPageTitlescope argument to thekbn-management-appdirective with two-way binding, and passes the value along to thebread-crumbsdirective.