Skip to content

Fix TSVB Visualizations to honor darkTheme - #12804

Merged
simianhacker merged 3 commits into
elastic:masterfrom
simianhacker:fix-12802
Jul 12, 2017
Merged

simianhacker merged 3 commits into
elastic:masterfrom
simianhacker:fix-12802

Conversation

@simianhacker

@simianhacker simianhacker commented Jul 12, 2017 •

Copy link
Copy Markdown
Member

This PR fixes TSVB to honor the darkTheme for dashboards. It also setups up the react_vis_type to pass appState as an argument to the component.

Closes #12802
Closes #12762

Before:

image

After:

image

@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) blocker release_note:fix v6.0.0 v6.0.0-beta1 labels Jul 12, 2017
@simianhacker
simianhacker merged commit 5e6a097 into elastic:master Jul 12, 2017
@simianhacker
simianhacker deleted the fix-12802 branch July 12, 2017 21:00
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* Fixes elastic#12802 - Fix TSVB Visualizations to honor darkTheme

* Sometimes appState doesn't exist

* Fixes elastic#12762 - Fixing propTypes to match props being passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix v6.0.0-beta1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSVB: Dark theme styling stopped working with visualize refactor TSVB: VisEditor component propTypes don't match the properties being passed

1 participant