Skip to content

fix spy panel on discovery page - #12853

Merged
ppisljar merged 3 commits into
elastic:masterfrom
ppisljar:fix/discoverSpy
Jul 17, 2017
Merged

ppisljar merged 3 commits into
elastic:masterfrom
ppisljar:fix/discoverSpy

Conversation

@ppisljar

Copy link
Copy Markdown
Contributor

closes #12836

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 labels Jul 14, 2017

@thomasneirynck thomasneirynck left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this works in Discovery.

the spy panel no longer displays on the Visualize page though. Just setting showSpyPanel=true in the visualization directive does the trick.

@nreese nreese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppisljar
ppisljar merged commit 7168858 into elastic:master Jul 17, 2017
@ppisljar
ppisljar deleted the fix/discoverSpy branch July 17, 2017 16:13
@jimgoodwin

Copy link
Copy Markdown

@ppisljar Release Note: paragraph please describing what was fixed

@thomasneirynck

Copy link
Copy Markdown
Contributor

Removing release note. Fixes a regression from the refactor, but this did not affect any users of v5.

@ppisljar
ppisljar restored the fix/discoverSpy branch September 26, 2018 10:06
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* adding show-spy-panel to visualization

* fix discover spy panel

* default editor should aways show spy panel toggle button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0-rc1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spy panel toggle button not showing up

4 participants