Skip to content

[UI Framework] Allow custom placeholder for Tool Bar Search Box - #12959

Merged
tsullivan merged 1 commit into
elastic:masterfrom
tsullivan:enhance/kui-toolbar-searchbox-custom-placeholder
Jul 20, 2017
Merged

tsullivan merged 1 commit into
elastic:masterfrom
tsullivan:enhance/kui-toolbar-searchbox-custom-placeholder

Conversation

@tsullivan

Copy link
Copy Markdown
Member

This allows users of the KuiToolBarSearch component to specify their own placeholder content. The current hardcoded placeholder content ("Search...") is pretty generic and doesn't suit all cases. If changing the filter doesn't actually kick off a search to the back-end, then using the content "Search" doesn't seem totally appropriate 😄

Screenshot:
image

@tsullivan tsullivan added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0 labels Jul 19, 2017

@stacey-gammon stacey-gammon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cjcenizal cjcenizal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@tsullivan
tsullivan merged commit cc95154 into elastic:master Jul 20, 2017
@tsullivan
tsullivan deleted the enhance/kui-toolbar-searchbox-custom-placeholder branch July 20, 2017 16:45
@tsullivan

Copy link
Copy Markdown
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0-rc1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants