Repository navigation
removes :filters from label - #12962
Conversation
|
Took me a little while to reproduce the problem. Split table with filters agg to reproduce. |
There was a problem hiding this comment.
This problem really affects any aggregation that does not implement makeLabel function and relies on the default implementation (which just returns the aggregation name). How about instead of hard coding to check against filters you check that agg.makeLabel() !== agg.name? A comment about why this check is needed would also be helpful.
|
jenkins, test this |
6f1c22a to
ca5e892
Compare
thomasneirynck
left a comment
There was a problem hiding this comment.
lgtm, but I'd recommend moving this more clear by moving the implementation of the evaluation to aggConfig. It will make code more readable and navigable.
| table.title = (table.fieldFormatter()(key)) + ': ' + agg.makeLabel(); | ||
| table.title = (table.fieldFormatter()(key)); | ||
| // aggs that don't implement makeLabel should not add to title | ||
| if (agg.makeLabel() !== agg.name) { |
There was a problem hiding this comment.
Can we make this a method on the aggConfig. Something like isAggConfigOverridden, along those lines.
closes #12827