Skip to content

[UI Framework] Reactify kuiEvent and related CSS components (#12226) - #12228

Merged
cjcenizal merged 1 commit into
elastic:masterfrom
PopradiArpad:uiframework/feature/reactify-event
Jun 7, 2017
Merged

cjcenizal merged 1 commit into
elastic:masterfrom
PopradiArpad:uiframework/feature/reactify-event

Conversation

@PopradiArpad

Copy link
Copy Markdown
Contributor

Implement

  • KuiEvent
  • KuiEventSymbol
  • KuiEventBody
  • KuiEventBodyMessage
  • KuiEventBodyMetadata

and theirs tests

Update docs examples.

…12226)

* Implement KuiEvent,KuiEventSymbol,KuiEventBody,
            KuiEventBodyMessage,KuiEventBodyMetadata
            and theirs tests

* Update docs examples
@PopradiArpad

Copy link
Copy Markdown
Contributor Author

It would be useful to have specialized KuiEventSymbols, like

  • KuiEventSymbolInfo
  • KuiEventSymbolWarning
  • KuiEventSymbolDanger

but I haven't made that, because I'm not sure whether it fits to the ui framework concept or should be made with another syntax.

@cjcenizal

Copy link
Copy Markdown
Contributor

@PopradiArpad That's an interesting idea! Let's hold off on it for now though, since we're still evolving our design language and I don't think we should bake these types of icons into the component quite yet. 😄

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. release_note:enhancement v6.0.0 v6.0.0-beta1 labels Jun 7, 2017

@cjcenizal cjcenizal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjcenizal

Copy link
Copy Markdown
Contributor

jenkins, test this

@cjcenizal
cjcenizal merged commit e2a5b27 into elastic:master Jun 7, 2017
@cjcenizal

Copy link
Copy Markdown
Contributor

Merged! Thanks for this!

@PopradiArpad
PopradiArpad deleted the uiframework/feature/reactify-event branch June 8, 2017 08:48
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
…12226) (elastic#12228)

* Implement KuiEvent,KuiEventSymbol,KuiEventBody,
            KuiEventBodyMessage,KuiEventBodyMetadata
            and theirs tests

* Update docs examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0-beta1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants