Repository navigation
[Discover] Add document explorer callout - #123814
Conversation
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
Thanks @dmitriynj . Do you mind adding screenshots of the UI changes this PR entails? It makes reviewing things much easier. |
…nt_explorer_callout/document_explorer_callout.tsx Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
|
@gchaps any feedback on the callout copy? To me "Check out new Document Explorer" feels like it not sure if it wants to be a title or sentence :) Any precedence here, perhaps "Try the new Document Explorer" or just "New Document Explorer". Also, I do like the list of pros in the paragraph, but should this be written as a statement versus as a question? It seems we could be a little more brief, here. Thanks for taking a look! @dmitriynj design-wise, this looks good. |
|
@elasticmachine merge upstream |
|
@ryankeairns What about something like this: A better way to explore Quickly sort and compare data, resize columns, and view more documents at once in the Document Explorer. |
I do like how succinct this is, thank you. We need to also work in the 'selectable' aspect that Matthias mentions in the comment thread above. Perhaps: "Quickly sort, select, and compare data, resize columns, and view more documents at once in the Document Explorer." Curious what others think, overall. |
I like this but I'm not sure about the "view more documents at once" part, what do we mean by that? |
|
I think "view more documents at once" means Full screen mode? |
kertal
left a comment
There was a problem hiding this comment.
Thx for applying the changes @dmitriynj 👍 , one more request, could you add test coverage? many thx!
|
kertal
left a comment
There was a problem hiding this comment.
LGTM 👍 tested a-la-carte, also with user without permissions to save Advanced settings. Work as expected.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
* [Discover] add document explorer callout * [Discover] fix mobile view * [Discover] fix lint * [Discover] apply suggestions * Update src/plugins/discover/public/application/main/components/document_explorer_callout/document_explorer_callout.tsx Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * [Discover] add unit tests, fix read only advanced settings case * [Discover] apply suggestions Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #123636
This PR adds callout for people who haven't disabled the Classic table in Advanced settings.
Checklist
Delete any items that are not applicable to this PR.