Skip to content

[Discover] Add document explorer callout - #123814

Merged
dimaanj merged 10 commits into
elastic:mainfrom
dimaanj:add-document-explorer-callout
Feb 1, 2022
Merged

dimaanj merged 10 commits into
elastic:mainfrom
dimaanj:add-document-explorer-callout

Conversation

@dimaanj

@dimaanj dimaanj commented Jan 26, 2022 •

Copy link
Copy Markdown
Contributor

Summary

Closes #123636

This PR adds callout for people who haven't disabled the Classic table in Advanced settings.

43768846-9F18-4C14-8A22-A196DA285FC0_1_105_c

Checklist

Delete any items that are not applicable to this PR.

@dimaanj dimaanj added Feature:Discover Discover Application release_note:feature Makes this part of the condensed release notes v8.1.0 Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Jan 26, 2022
@dimaanj dimaanj self-assigned this Jan 26, 2022
@dimaanj
dimaanj marked this pull request as ready for review January 26, 2022 18:35
@dimaanj
dimaanj requested review from a team as code owners January 26, 2022 18:35
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@ryankeairns

Copy link
Copy Markdown
Contributor

Thanks @dmitriynj . Do you mind adding screenshots of the UI changes this PR entails? It makes reviewing things much easier.

dimaanj and others added 2 commits January 27, 2022 17:45
…nt_explorer_callout/document_explorer_callout.tsx

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
@ryankeairns

Copy link
Copy Markdown
Contributor

@gchaps any feedback on the callout copy?

To me "Check out new Document Explorer" feels like it not sure if it wants to be a title or sentence :) Any precedence here, perhaps "Try the new Document Explorer" or just "New Document Explorer".

Also, I do like the list of pros in the paragraph, but should this be written as a statement versus as a question? It seems we could be a little more brief, here.

Thanks for taking a look!

@dmitriynj design-wise, this looks good.

@dimaanj

dimaanj commented Jan 27, 2022

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@gchaps

gchaps commented Jan 27, 2022 •

Copy link
Copy Markdown
Contributor

@ryankeairns What about something like this:

A better way to explore

Quickly sort and compare data, resize columns, and view more documents at once in the Document Explorer.

@ryankeairns

Copy link
Copy Markdown
Contributor

@ryankeairns What about something like this:

A better way to explore

Quickly sort and compare data, resize columns, and view more documents at once in the Document Explorer.

I do like how succinct this is, thank you. We need to also work in the 'selectable' aspect that Matthias mentions in the comment thread above. Perhaps:

"Quickly sort, select, and compare data, resize columns, and view more documents at once in the Document Explorer."
Is that punctuation correct? Is the comma after select needed?

Curious what others think, overall.

@andreadelrio

Copy link
Copy Markdown
Contributor

@ryankeairns What about something like this:
A better way to explore
Quickly sort and compare data, resize columns, and view more documents at once in the Document Explorer.

I do like how succinct this is, thank you. We need to also work in the 'selectable' aspect that Matthias mentions in the comment thread above. Perhaps:

"Quickly sort, select, and compare data, resize columns, and view more documents at once in the Document Explorer." Is that punctuation correct? Is the comma after select needed?

Curious what others think, overall.

I like this but I'm not sure about the "view more documents at once" part, what do we mean by that?

@kertal

kertal commented Jan 28, 2022

Copy link
Copy Markdown
Member

I think "view more documents at once" means Full screen mode?
Maybe "view more documents at once in the full screen mode"

@kertal kertal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for applying the changes @dmitriynj 👍 , one more request, could you add test coverage? many thx!

@gchaps

gchaps commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

A better way to explore
Quickly sort, select, and compare data, resize columns, and view documents in fullscreen with the Document Explorer.

@kertal kertal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 tested a-la-carte, also with user without permissions to save Advanced settings. Work as expected.

@dimaanj

dimaanj commented Jan 31, 2022

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci

Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 361 368 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 331.2KB 333.4KB +2.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj
dimaanj merged commit 41e756c into elastic:main Feb 1, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Feb 1, 2022
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* [Discover] add document explorer callout

* [Discover] fix mobile view

* [Discover] fix lint

* [Discover] apply suggestions

* Update src/plugins/discover/public/application/main/components/document_explorer_callout/document_explorer_callout.tsx

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* [Discover] add unit tests, fix read only advanced settings case

* [Discover] apply suggestions

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Discover Discover Application release_note:feature Makes this part of the condensed release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Discover] Add Document explorer callout

9 participants