Repository navigation
[Fleet] keep all agents selected in query selection mode - #135530
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Jun 30, 2022
kpollich
left a comment
Member
There was a problem hiding this comment.
LGTM - small change + added test assertion 🚀
Comment on lines
+356
to
+360
| } else { | ||
| // force selecting all agents on current page if staying in query mode | ||
| if (tableRef?.current) { | ||
| tableRef.current.setSelection(agents); | ||
| } |
Member
There was a problem hiding this comment.
Change makes sense to me. Thanks for the comment!
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Jun 30, 2022
(cherry picked from commit 19caaef)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2022
yakhinvadim
pushed a commit
to yakhinvadim/kibana
that referenced
this pull request
Jul 5, 2022
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #133523 (comment)
To verify:
Select everything on all pagesAll agents selectedlabel is still visible (query mode).Checklist