Repository navigation
[Discover] Fix filter in / filter out buttons for empty values - #135919
Merged
Merged
Conversation
jughosta
marked this pull request as ready for review
July 7, 2022 16:08
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @jughosta |
davismcphee
approved these changes
Jul 7, 2022
davismcphee
left a comment
Contributor
There was a problem hiding this comment.
Pulled and tested locally, LGTM!
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Jul 8, 2022
…ic#135919) * [Discover] Fix filter in / filter out buttons for empty values in the new grid * [Discover] Fix filter in / filter out buttons in the legacy table * [Discover] Simplify the code * [Discover] Add a test for legacy table (cherry picked from commit cead7b4) # Conflicts: # src/plugins/discover/public/components/discover_grid/discover_grid_cell_actions.tsx # src/plugins/discover/public/components/doc_table/components/table_row.tsx
jughosta
added a commit
that referenced
this pull request
Jul 8, 2022
…135919) (#135978) * [Discover] Fix filter in / filter out buttons for empty values (#135919) * [Discover] Fix filter in / filter out buttons for empty values in the new grid * [Discover] Fix filter in / filter out buttons in the legacy table * [Discover] Simplify the code * [Discover] Add a test for legacy table (cherry picked from commit cead7b4) # Conflicts: # src/plugins/discover/public/components/discover_grid/discover_grid_cell_actions.tsx # src/plugins/discover/public/components/doc_table/components/table_row.tsx * [Discover] Fix after the merge
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…ic#135919) * [Discover] Fix filter in / filter out buttons for empty values in the new grid * [Discover] Fix filter in / filter out buttons in the legacy table * [Discover] Simplify the code * [Discover] Add a test for legacy table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135912
Summary
This PR fixes issues with how Filter In / Filter Out buttons are handled for empty values in cells.
Checklist