Repository navigation
[Fleet] Pass start_time to actions when rolling upgrades maintenence window is set to immediately - #136384
Merged
criamico merged 3 commits intoJul 18, 2022
Conversation
…window is set to immediately
criamico
marked this pull request as ready for review
July 14, 2022 10:12
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
approved these changes
Jul 14, 2022
nchaulet
reviewed
Jul 14, 2022
Member
Author
|
Hi @michel-laterman, @nchaulet and I had a discussion about the
Can you confirm that we got the parameters correct? Basically we were missing case 2. |
Contributor
|
An action is scheduled by |
Member
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @criamico |
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2022
…window is set to immediately (#136384) * [Fleet] Pass start_time to actions when rolling upgrades maintenence window is set to immediately * Break up cases for rolling and scheduled upgrades Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e57d1f4)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2022
…window is set to immediately (#136384) (#136536) * [Fleet] Pass start_time to actions when rolling upgrades maintenence window is set to immediately * Break up cases for rolling and scheduled upgrades Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e57d1f4) Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…window is set to immediately (elastic#136384) * [Fleet] Pass start_time to actions when rolling upgrades maintenence window is set to immediately * Break up cases for rolling and scheduled upgrades Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136022
Summary
The possible parameters for upgrades are as follows:
This PR explicitely sets them following those three cases as the second one was missed.
I added an integration test to cover this specific case.
Checklist