Skip to content

pie chart design guidelines - #13661

Merged
ppisljar merged 1 commit into
elastic:masterfrom
ppisljar:design/pie
Oct 2, 2017
Merged

ppisljar merged 1 commit into
elastic:masterfrom
ppisljar:design/pie

Conversation

@ppisljar

Copy link
Copy Markdown
Contributor

implements #13328 for vislib pie chart

@ppisljar ppisljar added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Aug 23, 2017

@thomasneirynck thomasneirynck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. This also preserves the settings of older configurations, which is a nice bonus.

as for the hover state. imo it's a separate issue, and something we should look at for all charts, as it's shared logic for all line, bar, pie charts

@ppisljar ppisljar added v6.0.0 v6.1.0 v7.0.0 review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Aug 28, 2017
@alexfrancoeur

Copy link
Copy Markdown

Looks great @ppisljar! Glad to hear we're persisting the state of previously configured pie charts as well.
@snide I think we'll need an updated icon for the Add New Viz page

screen shot 2017-08-28 at 10 22 18 am

@thomasneirynck

Copy link
Copy Markdown
Contributor

I think this is OK to merge. We'll create a separate tracker to improve the icon.

@ppisljar
ppisljar merged commit dce23e6 into elastic:master Oct 2, 2017
ppisljar added a commit that referenced this pull request Oct 2, 2017
ppisljar added a commit that referenced this pull request Oct 2, 2017
@ppisljar

ppisljar commented Oct 2, 2017

Copy link
Copy Markdown
Contributor Author

backport:
6.x: 308c77c
6.0: f0d59ab

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0 v6.1.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants