Repository navigation
Make breadcrumb a heading for screen readers, fix #12885 - #13734
Merged
Merged
Conversation
timroes
requested review from
aphelionz,
cjcenizal,
ppisljar,
stacey-gammon and
weltenwort
August 28, 2017 15:28
timroes
added a commit
that referenced
this pull request
Aug 29, 2017
timroes
added a commit
that referenced
this pull request
Aug 29, 2017
Contributor
Author
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…tic#13734) * Make breadcrumb a heading for screen readers, fix elastic#12885 * Use h2 in vis wizard step 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #12885.
Instead of changing the visuals and adding a header to all those pages, I just annotated the breadcrumb navigation (or the title that is in the very same place) to be the level 1 header (equal to an
<h1>) on Visualize, Dashboards, and the surrounding documents listing. This PR doesn't change any visuals, just appliesrole=headingandaria-level=1to that elements, so that a screen reader will detect them as a heading (and they would be added to the landmarks navigation).