Repository navigation
updating time picker should not set vis to dirty - #13793
Merged
Merged
Conversation
thomasneirynck
approved these changes
Aug 31, 2017
Contributor
|
Since the category axis title is dynamically created each time the visualization is drawn, Why is the title even stored in the visState? Should |
Contributor
Author
|
@nreese yes, this PR should remove it |
Contributor
|
It is still in the state. |
Contributor
Author
|
@nreese is that a new visualization or an old one created before this PR ? i just tested,
|
ppisljar
added a commit
that referenced
this pull request
Sep 4, 2017
ppisljar
added a commit
that referenced
this pull request
Sep 4, 2017
Contributor
Author
|
backports: |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #13770
when i started working on this category axis title was a setting under category axis ... this is some left over code which was causing vis to go dirty every time the timepicker was updated