Skip to content

use parentNode iso parentElement - #13842

Merged
thomasneirynck merged 1 commit into
elastic:masterfrom
thomasneirynck:fix/ie11ParentNode
Sep 6, 2017
Merged

thomasneirynck merged 1 commit into
elastic:masterfrom
thomasneirynck:fix/ie11ParentNode

Conversation

@thomasneirynck

@thomasneirynck thomasneirynck commented Sep 5, 2017 •

Copy link
Copy Markdown
Contributor

Should use parentNode as parentElement isn't supported by IE for SVG elements. See #13830. This isn't an SVG element, but for consistency with the rest of the Kibana codebase, let's change it here too.

@thomasneirynck thomasneirynck changed the title use parentNode use parentNode iso parentElement Sep 5, 2017
@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) chore v6.0.0 v6.1.0 v7.0.0 labels Sep 5, 2017

@ppisljar ppisljar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck

Copy link
Copy Markdown
Contributor Author

jenkins, test this

@thomasneirynck
thomasneirynck merged commit f872c41 into elastic:master Sep 6, 2017
thomasneirynck added a commit that referenced this pull request Sep 6, 2017
thomasneirynck added a commit that referenced this pull request Sep 6, 2017
@thomasneirynck

Copy link
Copy Markdown
Contributor Author

backports:
6.x: e2e3177
6.0: be1ce81

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.0.0-rc1 v6.0.0 v6.1.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants