Skip to content

Fixes a bug with PR #13854 - #13873

Merged
simianhacker merged 1 commit into
elastic:masterfrom
simianhacker:fix-13854
Sep 7, 2017
Merged

simianhacker merged 1 commit into
elastic:masterfrom
simianhacker:fix-13854

Conversation

@simianhacker

Copy link
Copy Markdown
Member

This PR fixes a bug with PR #13854 where when the user types in an invalid interval pattern the screen goes blank because visData ends up being undefined. This PR ensures there is always a visData and model object.

@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 v6.0.0-rc1 v7.0.0 labels Sep 6, 2017

@thomasneirynck thomasneirynck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, I didn't realize something was up.. thx for follow up.

@ppisljar ppisljar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simianhacker
simianhacker merged commit 52cee7d into elastic:master Sep 7, 2017
simianhacker added a commit that referenced this pull request Sep 7, 2017
simianhacker added a commit that referenced this pull request Sep 7, 2017
@simianhacker

Copy link
Copy Markdown
Member Author

Back ported to 6.0 with bef94cb
Back ported to 6.x with 2391b7c

@simianhacker
simianhacker deleted the fix-13854 branch April 17, 2024 14:50
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0-rc1 v6.0.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants