Repository navigation
[6.x] Fix map updates not propagating to the dashboard (#13589) - #13883
Merged
stacey-gammon merged 1 commit intoSep 7, 2017
Merged
stacey-gammon merged 1 commit into
stacey-gammon merged 1 commit into
Conversation
* Add failing tests * Add fix by preventing uiState from being directly updated in visualization. * Add test that would catch error caused by this PR in regards to filter agg * Fix issue with uiState triggering dirty dashboard state by introducing temporary "sessionState" on a vis * Click go after toggling the switch * add more tests to ensure getRequestAggs functions as intented * Go back to old zoom calculations. Update vis test data I think because mapCollar is no longer saved in uiState, the save recenters the data and we get slightly different data points from the test data. As far as my eye can tell, everything is working as intended. * fixes and tests - incorporate the new init function which fixes the bug where we lose map bounds data on a fresh save - add a test that would have caught that - adjust tests due to bug where map bounds is changing slightly. File another issue for that separately as it doesn’t actually affect the users map experience. * Fix tests Tests relied on my original logic of defaulting to the saved zoom state and not relying on uiState, so I went back to that logic. Also found another bug where mapZoom of 0 was being considered invalid, but it is actually a valid zoom level. * Since leaflet upgrade 'path.leaflet-clickable' can't be used to retrieve circles anymore * Avoid stale element reference I suspect because the page is changing, you have to keep fetching the element afresh. I don’t see this error on my local but saw it on jenkins. * remove spy select from PageObjects.visualize.getDataTableData The function is used in the Data Table visualization where the spy pane select doesn’t exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports #13589
Add failing tests
Add fix by preventing uiState from being directly updated in visualization.
Add test that would catch error caused by this PR in regards to filter agg
Fix issue with uiState triggering dirty dashboard state by introducing temporary "sessionState" on a vis
Click go after toggling the switch
add more tests to ensure getRequestAggs functions as intented
Go back to old zoom calculations. Update vis test data
I think because mapCollar is no longer saved in uiState, the save
recenters the data and we get slightly different data points from the
test data. As far as my eye can tell, everything is working as
intended.
map bounds data on a fresh save
another issue for that separately as it doesn’t actually affect the
users map experience.
Tests relied on my original logic of defaulting to the saved zoom state
and not relying on uiState, so I went back to that logic. Also found
another bug where mapZoom of 0 was being considered invalid, but it is
actually a valid zoom level.
Since leaflet upgrade 'path.leaflet-clickable' can't be used to retrieve circles anymore
Avoid stale element reference
I suspect because the page is changing, you have to keep fetching the
element afresh. I don’t see this error on my local but saw it on
jenkins.
The function is used in the Data Table visualization where the spy pane
select doesn’t exist.