Skip to content

Add method to re-link visualizations with missing SavedSearch - #132729

Merged
alexwizp merged 5 commits into
elastic:mainfrom
alexwizp:mdn_savedSearch
May 25, 2022
Merged

Add method to re-link visualizations with missing SavedSearch#132729
alexwizp merged 5 commits into
elastic:mainfrom
alexwizp:mdn_savedSearch

Conversation

@alexwizp

@alexwizp alexwizp commented May 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to : #127203

Summary

This PR modifies the logic so that the user can open a classic visualization with a broken SavedSearch without navigating to the Listing Page

Screen

My.Movie.mp4

@alexwizp

alexwizp commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine

kibanamachine commented May 23, 2022

Copy link
Copy Markdown
Contributor

merge conflict between base and head

@alexwizp alexwizp changed the title Add method to re-link visualizations with missing savedSearchId Add method to re-link visualizations with missing SavedSearch May 24, 2022
@alexwizp
alexwizp requested a review from flash1293 May 24, 2022 10:29
@alexwizp alexwizp self-assigned this May 24, 2022
@alexwizp alexwizp added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.3.0 release_note:feature Makes this part of the condensed release notes backport:skip This PR does not require backporting labels May 24, 2022
@alexwizp
alexwizp marked this pull request as ready for review May 24, 2022 10:57
@alexwizp
alexwizp requested a review from a team as a code owner May 24, 2022 10:57
@elasticmachine

elasticmachine commented May 24, 2022

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

stratoula
stratoula previously approved these changes May 25, 2022
View reviewed changes

@stratoula stratoula left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I tested it quite thoroughly and it works fine. :)

Update: I haven't tested that, wrong approval 😬

@stratoula

stratoula commented May 25, 2022

Copy link
Copy Markdown
Contributor

@alexwizp do not merge it! I wanted to approve another PR and not this one! Sorry! This will be my next to test

@alexwizp
alexwizp requested a review from stratoula May 25, 2022 08:03
stratoula
stratoula reviewed May 25, 2022
View reviewed changes

@stratoula stratoula left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex this looks fine but I have 2 comments:
The first one is that when I choose the dataview, my chart is not rendered immediately, I have to change something on the editor in order to see it. So in my example I was using the flight logs saved search and I replaced it with the flights dataview, I was expecting to see data immediately
agg_based_search2

The other one might be irrelevant with this PR but there is a weird scroll on the editor for the broken viz
agg_based_search1

@alexwizp
alexwizp dismissed stratoula’s stale review May 25, 2022 08:42

wrong approval

@alexwizp
alexwizp requested a review from stratoula May 25, 2022 08:42
@alexwizp alexwizp mentioned this pull request May 25, 2022
Closed
@stratoula

stratoula commented May 25, 2022

Copy link
Copy Markdown
Contributor

@alexwizp this error message is weird :D
image

Other than that, now it works great :D

stratoula
stratoula approved these changes May 25, 2022
View reviewed changes

@stratoula stratoula left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works fine Alex 👍 LGTM!

@alexwizp
alexwizp enabled auto-merge (squash) May 25, 2022 13:42
@kibana-ci

kibana-ci commented May 25, 2022

Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 293.9KB 287.7KB -6.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 46.9KB 46.8KB -96.0B
Unknown metric groups

async chunk count

id before after diff
visualizations 13 14 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp
alexwizp merged commit e0ab71a into elastic:main May 25, 2022
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@alexwizp @stratoula
Add method to re-link visualizations with missing SavedSearch (elas…
04b63de 
…tic#132729)

* Add method to re-link visualizations with missing SavedSearch elastic#132729

* push updates

* fix issue with agg config

* fix broken error message

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes
@flash1293 flash1293 Awaiting requested review from flash1293

Assignees

@alexwizp alexwizp

Labels

backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexwizp @kibanamachine @elasticmachine @stratoula @kibana-ci