Skip to content

[8.3] [APM] Add ML expected model bounds as an option to Comparison controls (#132456) - #133825

Closed
sorenlouv wants to merge 1 commit into
elastic:8.3from
sorenlouv:backport/8.3/pr-132456
Closed

sorenlouv wants to merge 1 commit into
elastic:8.3from
sorenlouv:backport/8.3/pr-132456

Conversation

@sorenlouv

Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.3:

Questions ?

Please refer to the Backport tool documentation

@sorenlouv sorenlouv added the backport This PR is a backport of another PR label Jun 7, 2022
@sorenlouv
sorenlouv enabled auto-merge (squash) June 7, 2022 18:59
@botelastic botelastic Bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 7, 2022
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv

Copy link
Copy Markdown
Contributor Author

Replaced by #133826

@sorenlouv sorenlouv closed this Jun 7, 2022
auto-merge was automatically disabled June 7, 2022 19:29

Pull request was closed

@sorenlouv
sorenlouv deleted the backport/8.3/pr-132456 branch June 7, 2022 20:04
@sorenlouv
sorenlouv restored the backport/8.3/pr-132456 branch June 7, 2022 22:56
@sorenlouv sorenlouv reopened this Jun 7, 2022
#132456)

* [ML] Add bounds options

* [ML] Renable anomalyChartTimeseries boundaries

* [ML] Make it into string

* [ML] Make it into string

* Match colors

* [ML] Add comparisonEnabledRt

* [ML] Fix types, tests

* [ML] Revert json bucket span change

* [ML] Add bounds options

* [ML] Renable anomalyChartTimeseries boundaries

* [ML] Make it into string

* [ML] Make it into string

* Match colors

* [ML] Add comparisonEnabledRt

* [ML] Fix types, tests

* [ML] Revert json bucket span change

* Refactor to use offset with TimeRangeComparisonEnum.ExpectedBounds

* Change comparisonColor to be part of anomalySeries

* Fix i18n

* Add Comparison text to replace 'Previous period'

* Fix expected bounds legend default to first

* Hide values that are N/A in the tooltips

* Fix i18n, color, and null values in tooltips

* Refactor to use preferredEnvironment

* Don't disable expected bounds by default

* Match color of expected bounds with time comparison color

* Fix tests

* Use bucket_span as minBucketSize for anomaly results

* Fix previousPeriodColor undefined for latency chart

* Remove 'Comparison:' in legend

* Change anomalyTimeseriesColor to use currentPeriod to match stuff

* Fix type error

* Fix lower model bounds

* Add comments

* Remove fit

* Remove comparisonEnabledRt

* Change text

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c1d0ec5)
@kibana-ci

kibana-ci commented Jun 7, 2022 •

Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1213 1214 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.9MB 2.9MB +2.0KB

History

  • 💔 Build #49702 failed 3e459523b1d17b769f901bc72482fa75f20c9738

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv closed this Jun 8, 2022
@sorenlouv
sorenlouv deleted the backport/8.3/pr-132456 branch June 8, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:APM - DEPRECATED Use Team:obs-ux-infra_services.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants