Repository navigation
[TSVB] Allow negative time offsets - #14494
Merged
Merged
Conversation
Contributor
Author
|
Jenkins test this |
ppisljar
approved these changes
Oct 23, 2017
ppisljar
left a comment
Contributor
There was a problem hiding this comment.
LGTM, failling test seems to be unrelated
simianhacker
approved these changes
Oct 23, 2017
|
|
||
| const expandStyle = Object.assign({}, expandChildStyle, { | ||
| const expandStyle = { | ||
| ...expandChildStyle, |
Member
There was a problem hiding this comment.
If you pull from master you shouldn't have to fix this.
Contributor
Author
|
Jenkins, test this |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Oct 25, 2017
* Allow negative offsets in TSVB * Fix linting issue
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Oct 25, 2017
* Allow negative offsets in TSVB * Fix linting issue
timroes
added a commit
that referenced
this pull request
Oct 25, 2017
timroes
added a commit
that referenced
this pull request
Oct 25, 2017
Contributor
Author
|
negative offsets seem to move the chart timespan, while positive offsets move the data within the chart? |
|
I think the positive offset is doing what I expect. It's shifting the data by the offset so that you could compare one series to another one from a previous week or other time period. But the negative offset just moved the range of data being displayed from |
Member
|
Whoops... I felt like I tested this but now looking at #15554 I guess it slipped past me. |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Allow negative offsets in TSVB * Fix linting issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TSVB currently doesn't allow specifying negative time offsets, due to the way it validates the offset format.
This PR fixes that behavior and also allows negative time offsets and also allows specifying the positive time offset with the plus sign as a prefix.