[Fleet] Agent activity by juliaElastic · Pull Request #140510 · elastic/kibana

juliaElastic · 2022-09-12T13:46:42Z

Summary

Resolves #140267

Added agent activity flyout following the new design.

Agent activity button on agent list page, next to Add agent buttons.
Flyout showing In progress and completed actions in descending time order.
Upgrade callout and abort moved to flyout
Added tour for first time after action is taken from UI

Pending:

adding tests
(Done) update texts everywhere with i18n
openapi update

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2022-09-13T13:19:03Z

Pinging @elastic/fleet (Team:Fleet)

kpollich

A few patterns in the code here that I think are worth changing. Haven't gotten a chance to pull down locally and test (will do so tomorrow), but overall things are looking great here. Thanks for putting this together so quickly @juliaElastic!

nchaulet · 2022-09-14T20:54:35Z

Should we clean somehow the unenroll action when the user force unenroll an agent? (probably a follow up issue)

Here I unenrolled an offline agent, than force unenrolled and the UI is stuck with this

juliaElastic · 2022-09-15T08:06:37Z

Should we clean somehow the unenroll action when the user force unenroll an agent? (probably a follow up issue)

Here I unenrolled an offline agent, than force unenrolled and the UI is stuck with this

Good point, I think this is an existing issue made visible with the activity flyout. This could be improved by kibana querying any in progress unenroll actions for the agents being force unenrolled, and making them completed. I would take this to a separate issue.

Created: #140794

There is a similar issue with stuck in progress actions in case of validation failures, commented here: #141567

nchaulet

Looks good to me 🚀

juliaElastic · 2022-09-15T12:20:27Z

@kpollich are you ready to approve? I updated the requested changes.

kpollich

All comments addressed so LGTM 🚀

kibana-ci · 2022-09-15T13:18:19Z

💚 Build Succeeded

Buildkite Build
Commit: e0055ee

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	719	721	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	869.6KB	879.4KB	+9.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	105.9KB	105.9KB	-3.0B

History

💚 Build #72623 succeeded 8bc0266
💚 Build #72570 succeeded bb71297
💚 Build #72530 succeeded cd41522
💚 Build #72235 succeeded 67b4621
💔 Build #72161 failed ea7cfbc
💔 Build #72136 failed cba25e1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

ghost · 2022-09-26T11:37:24Z

Hi @juliaElastic ,

We have created below 13 test cases for this feature under our Fleet Test Suite:

[C167989]: Validate that ‘Agent activity history’ pop-up is shown on re-assigning policy, upgrade, and unenrolling agents
[C167990]: Validate that ‘No activity to display’ text is shown on ‘Agent activity’ flyout when no action is performed on the agent
[C167991]: Validate that ‘Agent activity’ with clock icon is shown on the Fleet > Agents page
[C167992]: Validate ‘Agent activity’ flyout gets opened on clicking ‘Agent activity’ link on Fleet > Agents page
[C167993]: Validate that ‘X agent upgraded’ is shown in green color with a tick sign on ‘Agent activity’ flyout on schedule upgrading ‘X agent’
[C167994]: Validate that ‘Agent upgrade cancelled’ is shown in gray color with a triangle sign on clicking ‘Abort upgrade’ on ‘Agent activity’ flyout
[C167995]: Validate that ‘x agent/agents assigned to a new policy’ is shown on ‘Agent activity’ flyout on assigning new policy to the x agent/agents
[C167996]: Validate that ‘X agent upgraded’ is shown in green color with a tick sign on ‘Agent activity’ flyout on upgrading ‘x agent’
[C167997]: Validate that ‘x agent/agents force unenrolled’ is shown on ‘Agent activity’ flyout on force unenrolling x agent/agents.
[C167998]: Validate that the ‘In progress’ section is shown at the top
[C167999]: Validate that ‘X1 of X agents upgraded’ is shown in red color on ‘Agent activity’ flyout on agents upgrade failure
[C168000]: Validate that ‘X1 of X agent is assigned to a new policy’ is shown in red color on ‘Agent activity’ flyout on agent not added to new policy
[C168001]: Validate that ‘x agent/agents unenrolled’ is shown on ‘Agent activity’ flyout on unenrolling x agent/agents

Query

Could you please confirm when and how many times will 'Agent activity history' pop would be shown as we are getting the pop-up inconsistently many times.

Please review the test cases and let us know if we are missing anything.

Thanks!

juliaElastic · 2022-09-26T13:39:19Z

@prachigupta-qasource One more scenario can be added: update agent tags will show up now in Agent activity as well: #141376

Could you please confirm when and how many times will 'Agent activity history' pop would be shown as we are getting the pop-up inconsistently many times.

The tour should show up for the first time one of these actions are taken. After that, the tour should be hidden on that cluster (there is a ui setting saved for this).

ghost · 2022-09-29T06:32:38Z

Hi @juliaElastic ,

Thank you for the update.

We have created below 01 test case for this feature under our Fleet Test Suite:

[C168020]: Validate that ‘X agent/agents updated tags’ is shown on ‘Agent activity’ flyout on updating tags for X agent/agents

Please review the test case and let us know if we are missing anything.

Thanks!

ghost · 2022-10-04T10:46:06Z

Hi Team,

We have executed 15 testcases for this feature under our Fleet Test run at Fleet 8.5.0-BC2 Feature test plan.

Below are the observations:

Passed: 13
Failed: 02 due to bug [Fleet]: No appropriate agent upgrade failed message is available if agents fails to upgrade to the latest version. #140936 and [Fleet]: '1 agent updated tags' is not shown on 'Agent activity' flyout for Updating Tags for one agent #142557

Build details:

Version: 8.5.0 BC2
Build: 56806
Commit: dc769f45a5a6dafb0a8c8f0c0cabcced4df45e11

Thanks!

ghost · 2022-11-07T08:53:29Z

Hi @juliaElastic,

As per this issue #144299, we have created 01 test case for this feature under our Fleet Test Suite:

[C168233]: Validate that ‘1 agent updated settings’ is shown on ‘Agent activity’ flyout on changing the ‘Agent logging level’

Please let us know if anything else is required from our end.

Thanks!

* WIP: agent activity flyout * added missing info to action_status api and UI * refactored action status api to use aggs for action results * made flyout button visible on selection, refactor * added tour around Agent activity button * formatted texts * query failed actions, review comments * catch errors * updated empty prompt * fix test * added flyout footer * fix test * fix test * updated in progress activity * updated failed activity with started time * added openapi spec, added nbAgentsFailed to action status * small tweak of in progress display and upgrade toast

juliaElastic added 3 commits September 12, 2022 15:44

WIP: agent activity flyout

04be4c9

added missing info to action_status api and UI

8772f73

refactored action status api to use aggs for action results

8dc3e56

juliaElastic self-assigned this Sep 12, 2022

juliaElastic added release_note:feature Makes this part of the condensed release notes v8.5.0 labels Sep 12, 2022

juliaElastic and others added 2 commits September 12, 2022 15:47

Merge branch 'main' into feat/agent-activity-rebased

835e197

made flyout button visible on selection, refactor

8c7f449

juliaElastic marked this pull request as ready for review September 13, 2022 11:59

juliaElastic requested a review from a team as a code owner September 13, 2022 11:59

added tour around Agent activity button

0c0348d

botelastic Bot added the Team:Fleet - DEPRECATED Use Team:streams-ui label Sep 13, 2022

formatted texts

efa630b

nchaulet reviewed Sep 13, 2022

View reviewed changes

Comment thread ...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_button.tsx Outdated

kpollich requested changes Sep 13, 2022

View reviewed changes

juliaElastic and others added 3 commits September 14, 2022 10:36

query failed actions, review comments

7607e2e

catch errors

aed77b2

Merge branch 'main' into feat/agent-activity-rebased

60f86d3

juliaElastic requested review from kpollich and nchaulet September 14, 2022 10:00

joshdover mentioned this pull request Sep 14, 2022

[Feature Request][Fleet] Be able to see which agents are being upgraded from the UI. #139815

Open

juliaElastic added 5 commits September 14, 2022 13:14

updated empty prompt

f8538db

fix test

cba25e1

added flyout footer

290327c

fix test

ea7cfbc

fix test

67b4621

updated in progress activity

cd41522

updated failed activity with started time

bb71297

juliaElastic mentioned this pull request Sep 15, 2022

[Fleet] Unenroll action is stuck in progress after force unenroll agent #140794

Closed

added openapi spec, added nbAgentsFailed to action status

8bc0266

nchaulet approved these changes Sep 15, 2022

View reviewed changes

small tweak of in progress display and upgrade toast

e0055ee

kpollich approved these changes Sep 15, 2022

View reviewed changes

juliaElastic merged commit 1709be2 into elastic:main Sep 15, 2022

kibanamachine added the backport:skip This PR does not require backporting label Sep 15, 2022

juliaElastic mentioned this pull request Sep 15, 2022

[Fleet] Agent activity flyout #140267

Closed

This was referenced Sep 19, 2022

[Fleet]: No pop is shown on hovering over 'Agent activity' link #140911

Closed

[Question][Fleet]: Two different screenshots are shown for 'View agents' link feature on 'Agent activity' flyout #141025

Closed

joshdover added the QA:Needs Validation Issue needs to be validated by QA label Sep 21, 2022

dikshachauhan-qasource mentioned this pull request Mar 6, 2023

[Fleet] ‘In progress’ section is not shown at the top Agent Activity Flyout, when user assigns a new policy. #152696

Closed

amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Needs Validation Issue needs to be validated by QA labels Mar 28, 2024

Conversation

juliaElastic commented Sep 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Sep 13, 2022

Uh oh!

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nchaulet commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliaElastic commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

juliaElastic commented Sep 15, 2022

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Sep 15, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

ghost commented Sep 26, 2022

Query

Uh oh!

juliaElastic commented Sep 26, 2022

Uh oh!

ghost commented Sep 29, 2022

Uh oh!

ghost commented Oct 4, 2022

Uh oh!

ghost commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

juliaElastic commented Sep 12, 2022 •

edited

Loading

nchaulet commented Sep 14, 2022 •

edited

Loading

juliaElastic commented Sep 15, 2022 •

edited

Loading