Repository navigation
apply field formatter to tag cloud - #14230
Merged
Merged
Conversation
ppisljar
approved these changes
Oct 2, 2017
ppisljar
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a minor comment about $scope.$apply, if we can get rid of it that would be even better
| const aggs = $scope.vis.getAggConfig().getResponseAggs(); | ||
| const aggConfigResult = new AggConfigResult(aggs[0], false, event, event); | ||
| clickHandler({ point: { aggConfigResult: aggConfigResult } }); | ||
| $scope.$apply(); |
Contributor
There was a problem hiding this comment.
is this really needed ? are you sure it will never run in the middle of digest cycle ?
Contributor
Author
There was a problem hiding this comment.
Not sure about never running in the middle of the digest cycle but without it - the filter is not created until you do soemthing else that runs a digest cycle
Contributor
There was a problem hiding this comment.
what about using the new vis.type.API.click ?
thomasneirynck
approved these changes
Oct 3, 2017
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 4, 2017
* apply field formatter to tag cloud * use unformatted value for filter creation
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 4, 2017
* apply field formatter to tag cloud * use unformatted value for filter creation
nreese
added a commit
that referenced
this pull request
Oct 4, 2017
nreese
added a commit
that referenced
this pull request
Oct 4, 2017
* apply field formatter to tag cloud (#14230) * apply field formatter to tag cloud * use unformatted value for filter creation * add removeFilter for functional tests
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* apply field formatter to tag cloud * use unformatted value for filter creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12069
Applies field formatter to tag cloud labels