Repository navigation
Eslint/remove last amd modules - #14282
Merged
Merged
Conversation
tylersmalley
approved these changes
Oct 9, 2017
tylersmalley
left a comment
Member
There was a problem hiding this comment.
LGTM, though I am not entirely sure how we handle publishing.
spalger
added a commit
that referenced
this pull request
Oct 10, 2017
* [timelion] remove last remaining amd modules * [eslint-config-kibana] remove env.amd (cherry picked from commit bd53cc6)
spalger
added a commit
that referenced
this pull request
Oct 10, 2017
* [timelion] remove last remaining amd modules * [eslint-config-kibana] remove env.amd (cherry picked from commit bd53cc6)
Contributor
Author
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [timelion] remove last remaining amd modules * [eslint-config-kibana] remove env.amd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the last couple amd modules and removes the
env.amdsetting in the eslint-config. I'm not sure how we handle publishing changes to these modules, but I included the version number and will runnpm publishonce this is merged. (If we do it differently please let me know)