Repository navigation
Handle ES _default_ mapping type (#14934) - #15432
Merged
tylersmalley merged 3 commits intoDec 12, 2017
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
Member
|
Jenkins, test it |
tylersmalley
reviewed
Dec 7, 2017
| */ | ||
| export function getTypes(mappings) { | ||
| return Object.keys(mappings); | ||
| return Object.keys(mappings).filter(type => !type.match(/^_default_$/)); |
Member
There was a problem hiding this comment.
A string comparison would probably be better here.
return Object.keys(mappings).filter(type => type !== '_default_');
Contributor
Author
There was a problem hiding this comment.
sure thing. pushed.
tylersmalley
pushed a commit
that referenced
this pull request
Dec 12, 2017
tylersmalley
pushed a commit
that referenced
this pull request
Dec 12, 2017
Member
tylersmalley
pushed a commit
that referenced
this pull request
Dec 12, 2017
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
_default_keysolution
'_default_'when checking mapping types