Repository navigation
Truncate long names in the discover index pattern selection - #15510
Merged
Merged
Conversation
lukasolson
suggested changes
Dec 11, 2017
lukasolson
left a comment
Contributor
There was a problem hiding this comment.
Instead of adding custom CSS here you could follow the same pattern that the filter editor uses and change the markup from this
<ui-select-match>
{{$select.selected.get('title')}}
</ui-select-match>to this
<ui-select-match>
<span
class="uiSelectMatch--ellipsis"
tooltip="{{$select.selected.get('title')}}"
>
{{$select.selected.get('title')}}
</span>
</ui-select-match>This has the added benefit of adding the tooltip when it overflows the content so you can still see what you've got selected if you hover over it.
Contributor
Author
|
@lukasolson Great idea, updated. |
Bargs
commented
Dec 11, 2017
| <span | ||
| class="uiSelectMatch--ellipsis" | ||
| tooltip="{{$select.selected.get('title')}}" | ||
| tooltip-append-to-body="true" |
Contributor
Author
There was a problem hiding this comment.
Had to append to body otherwise the left nav would overlap the tooltip.
lukasolson
approved these changes
Dec 12, 2017
lukasolson
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for moving that CSS style.
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Dec 15, 2017
Bargs
added a commit
that referenced
this pull request
Dec 15, 2017
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15364
Hides overflow and adds ellipsis.