Repository navigation
refactoring vis uiState - #15709
Merged
Merged
refactoring vis uiState#15709
Conversation
ppisljar
commented
Dec 20, 2017
Contributor
Author
There was a problem hiding this comment.
what if vis has a uiState before this gets called ?
what if $scope.uiState is different from the one set on vis ? which one should prevail ?
Contributor
Author
There was a problem hiding this comment.
(currently the one set on visualize/visualization will override the one set on Vis)
timroes
self-requested a review
December 20, 2017 17:05
timroes
approved these changes
Dec 22, 2017
timroes
left a comment
Contributor
There was a problem hiding this comment.
The code itself looks good to me. The test failures though seem to be related to the change. If the tests pass, this is a LGTM.
Contributor
Author
|
jenkins, test this |
timroes
reviewed
Dec 22, 2017
Contributor
There was a problem hiding this comment.
/**
* This is an internal method only meant to be used inside the visualization code.
* You shouldn't call it when working with the `vis` class.
* You should rely on the visualization code you are using (loader, <visualize/>, <visualization/>)
* to use and set the uiState, that you passed to it.
*/
timroes
reviewed
Dec 22, 2017
Contributor
There was a problem hiding this comment.
Well that didn't quite work as expected 😛
ppisljar
force-pushed
the
fix/uiState
branch
2 times, most recently
from
January 3, 2018 17:04
f0bab53 to
b0e783c
Compare
ppisljar
force-pushed
the
fix/uiState
branch
2 times, most recently
from
January 4, 2018 13:02
2cfa721 to
464283a
Compare
Contributor
Author
|
selenium tests failed (seems unrelated table test) jenkins, test this |
thomasneirynck
self-requested a review
January 4, 2018 15:32
thomasneirynck
approved these changes
Jan 4, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Jan 4, 2018
ppisljar
added a commit
that referenced
this pull request
Jan 5, 2018
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #15703
Visas its no longer usedVisconstructor as it was only used by clone method