Repository navigation
Only apply forced max mode when panel is shown - #15752
Merged
Merged
Conversation
ppisljar
approved these changes
Dec 22, 2017
ppisljar
left a comment
Contributor
There was a problem hiding this comment.
LGTM, once the tests pass
|
jenkins, test this |
|
jenkins, test this |
stacey-gammon
approved these changes
Dec 22, 2017
stacey-gammon
left a comment
There was a problem hiding this comment.
lgtm and fixes the issue, but prob want to wait till you can trigger a build and get it green. Not sure why but jenkins doesn't seem to be firing
Contributor
Author
|
Jenkins, test this |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Dec 23, 2017
timroes
added a commit
that referenced
this pull request
Dec 23, 2017
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #15742 where vis appear not to render on dashboard.
This bug was caused by the spy panel refactoring. It checked whether the remaining vis size after a rendering would be below 180px and in this case make the spy fullscreen automatically (same behavior as beforehand). Unfortunately I forgot to check if the spy panel is actually open, so it applied the class also after rendering if the spy panel was closed and smaller then 180px, which cause it to
display: none.This PR now checks if
$scope.currentModeis set (it's set to the name of the open spypanel ornullif it's closed), before setting theforceMaximizedwhich itself will trigger setting the class in a watch a bit down in thespy.jsfile.