Skip to content

Set list-style-type for list items in markdown-body - #15827

Merged
nreese merged 2 commits into
elastic:masterfrom
nreese:markdown_list_style
Jan 3, 2018
Merged

nreese merged 2 commits into
elastic:masterfrom
nreese:markdown_list_style

Conversation

@nreese

@nreese nreese commented Jan 3, 2018

Copy link
Copy Markdown
Contributor

Kibana sets list-style: none so list items in markdown do not have any styling. This is a new change and breaks the expected behavior of markdown styling. This PR sets list-style-type for lists under .markdown-body.

before

screen shot 2018-01-03 at 8 23 46 am

after

screen shot 2018-01-03 at 8 24 32 am

@nreese
nreese requested review from cchaos and snide January 3, 2018 15:32
@nreese nreese added release_note:fix Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.2.0 v7.0.0 labels Jan 3, 2018
}

// Kibana sets list-style: none. Need to restore list styles for markdown
.markdown-body ul li {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to apply the list style to the whole list, i.e. ul, not the list item?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason. I will apply the style to the list element

@cchaos cchaos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nreese
nreese merged commit d72c9a5 into elastic:master Jan 3, 2018
nreese added a commit to nreese/kibana that referenced this pull request Jan 3, 2018
* fix markdown list style broken by EUI

* apply style to list element instead of item element
nreese added a commit that referenced this pull request Jan 3, 2018
* fix markdown list style broken by EUI

* apply style to list element instead of item element
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* fix markdown list style broken by EUI

* apply style to list element instead of item element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.2.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants