Repository navigation
Tidy up serve.js - #158706
Closed
delanni wants to merge 3 commits into
Closed
Tidy up serve.js#158706delanni wants to merge 3 commits into
delanni wants to merge 3 commits into
Conversation
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
afharo
approved these changes
Jun 1, 2023
| const root = new Root(rawConfigService, env, onRootShutdown); | ||
|
|
||
| const cliLogger = root.logger.get('cli'); | ||
| cliLogger.info('Configurations parsed in this order: ' + env.configs.join(', ')); |
Member
There was a problem hiding this comment.
nit: since this log will be presented to users, should we explain that the ones on the right override the ones on the left?
jbudz
reviewed
Jun 1, 2023
| [ | ||
| 'kibana.dev.yml', | ||
| 'serverless.dev.yml', | ||
| // 'serverless.es.dev.yml' // Shouldn't this be loaded? It's mentioned in the README, but wasn't in the code |
Contributor
There was a problem hiding this comment.
We've typically left the dev.yml convention uncommitted and untracked as a way for developers to persist setups. Optionally loaded.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #155137
Does some simple refactors as suggested in the original PR.
Checklist