Repository navigation
Change kibana.alert.evaluation.threshold unit to microseconds - #158703
Merged
maryam-saeidi merged 1 commit intoJun 1, 2023
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
fkanout
self-requested a review
May 31, 2023 14:07
fkanout
approved these changes
May 31, 2023
fkanout
left a comment
Contributor
There was a problem hiding this comment.
The latency chart threshold annotation is fixed too. Nice work @maryam-saeidi !
Contributor
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
sorenlouv
reviewed
Jun 1, 2023
| value: formatAlertEvaluationValue( | ||
| alert?.fields[ALERT_RULE_TYPE_ID], | ||
| toMicroseconds(alert?.fields[ALERT_EVALUATION_THRESHOLD]) | ||
| alert?.fields[ALERT_EVALUATION_THRESHOLD] |
Contributor
There was a problem hiding this comment.
It looks like alert?.fields[ALERT_EVALUATION_THRESHOLD] was previously in milliseconds but going forward it will be in microseconds? Where does this happen?
Member
Author
There was a problem hiding this comment.
Here is the change: (next file change in this PR)
[ALERT_EVALUATION_THRESHOLD]: thresholdMicroseconds,
sorenlouv
approved these changes
Jun 1, 2023
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
maryam-saeidi
added a commit
to maryam-saeidi/kibana
that referenced
this pull request
Jun 1, 2023
…c#158703) Resolves elastic#156255 Fixes elastic#158204 Partially reverts elastic#154801 [RFC Document](https://docs.google.com/document/d/1-O6-nqOedrjtTF9mHawd_u-vUdXu06KGI8ic5qNeQPQ/edit?usp=sharing) This PR changes kibana.alert.evaluation.threshold unit to microseconds in AAD. |Case|Screenshot| |----|---| |Saved value in AAD|| |Should show correct information in flyout|| |Should show correct information on alert details page|| |Should show correct information in action message|| |Same unit for value and threshold in the alert table|| - Generate an APM Latency threshold alert - Check the threshold in - Alert's flyout - Alert's table - Alert details page (summary and chart) - Action generated by this alert (cherry picked from commit d13f884)
This was referenced Jun 1, 2023
maryam-saeidi
added a commit
to maryam-saeidi/kibana
that referenced
this pull request
Jun 5, 2023
…c#158703) Resolves elastic#156255 Fixes elastic#158204 Partially reverts elastic#154801 [RFC Document](https://docs.google.com/document/d/1-O6-nqOedrjtTF9mHawd_u-vUdXu06KGI8ic5qNeQPQ/edit?usp=sharing) ## Summary This PR changes kibana.alert.evaluation.threshold unit to microseconds in AAD. |Case|Screenshot| |----|---| |Saved value in AAD|| |Should show correct information in flyout|| |Should show correct information on alert details page|| |Should show correct information in action message|| |Same unit for value and threshold in the alert table|| ## 🧪 How to test - Generate an APM Latency threshold alert - Check the threshold in - Alert's flyout - Alert's table - Alert details page (summary and chart) - Action generated by this alert (cherry picked from commit d13f884) # Conflicts: # x-pack/plugins/apm/public/components/alerting/ui_components/alert_details_app_section/index.tsx # x-pack/plugins/observability/public/components/alerts_flyout_body.tsx
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
maryam-saeidi
added a commit
that referenced
this pull request
Jun 5, 2023
…158703) (#159013) # Backport This will backport the following commits from `main` to `8.8`: - [Change kibana.alert.evaluation.threshold unit to microseconds (#158703)](#158703) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T11:12:21Z","message":"Change kibana.alert.evaluation.threshold unit to microseconds (#158703)\n\nResolves #156255\r\nFixes #158204\r\nPartially reverts #154801\r\n\r\n[RFC\r\nDocument](https://docs.google.com/document/d/1-O6-nqOedrjtTF9mHawd_u-vUdXu06KGI8ic5qNeQPQ/edit?usp=sharing)\r\n\r\n## Summary\r\n\r\nThis PR changes kibana.alert.evaluation.threshold unit to microseconds\r\nin AAD.\r\n\r\n|Case|Screenshot|\r\n|----|---|\r\n|Saved value in\r\nAAD||\r\n|Should show correct information in\r\nflyout||\r\n|Should show correct information on alert details\r\npage||\r\n|Should show correct information in action\r\nmessage||\r\n|Same unit for value and threshold in the alert\r\ntable||\r\n\r\n\r\n## 🧪 How to test\r\n- Generate an APM Latency threshold alert\r\n- Check the threshold in\r\n - Alert's flyout\r\n - Alert's table\r\n - Alert details page (summary and chart)\r\n - Action generated by this alert","sha":"d13f884ec3a4e61fcc23e5594741ec436fa4c4fb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","Team: Actionable Observability","backport:prev-minor","v8.9.0"],"number":158703,"url":"https://github.com/elastic/kibana/pull/158703","mergeCommit":{"message":"Change kibana.alert.evaluation.threshold unit to microseconds (#158703)\n\nResolves #156255\r\nFixes #158204\r\nPartially reverts #154801\r\n\r\n[RFC\r\nDocument](https://docs.google.com/document/d/1-O6-nqOedrjtTF9mHawd_u-vUdXu06KGI8ic5qNeQPQ/edit?usp=sharing)\r\n\r\n## Summary\r\n\r\nThis PR changes kibana.alert.evaluation.threshold unit to microseconds\r\nin AAD.\r\n\r\n|Case|Screenshot|\r\n|----|---|\r\n|Saved value in\r\nAAD||\r\n|Should show correct information in\r\nflyout||\r\n|Should show correct information on alert details\r\npage||\r\n|Should show correct information in action\r\nmessage||\r\n|Same unit for value and threshold in the alert\r\ntable||\r\n\r\n\r\n## 🧪 How to test\r\n- Generate an APM Latency threshold alert\r\n- Check the threshold in\r\n - Alert's flyout\r\n - Alert's table\r\n - Alert details page (summary and chart)\r\n - Action generated by this alert","sha":"d13f884ec3a4e61fcc23e5594741ec436fa4c4fb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158703","number":158703,"mergeCommit":{"message":"Change kibana.alert.evaluation.threshold unit to microseconds (#158703)\n\nResolves #156255\r\nFixes #158204\r\nPartially reverts #154801\r\n\r\n[RFC\r\nDocument](https://docs.google.com/document/d/1-O6-nqOedrjtTF9mHawd_u-vUdXu06KGI8ic5qNeQPQ/edit?usp=sharing)\r\n\r\n## Summary\r\n\r\nThis PR changes kibana.alert.evaluation.threshold unit to microseconds\r\nin AAD.\r\n\r\n|Case|Screenshot|\r\n|----|---|\r\n|Saved value in\r\nAAD||\r\n|Should show correct information in\r\nflyout||\r\n|Should show correct information on alert details\r\npage||\r\n|Should show correct information in action\r\nmessage||\r\n|Same unit for value and threshold in the alert\r\ntable||\r\n\r\n\r\n## 🧪 How to test\r\n- Generate an APM Latency threshold alert\r\n- Check the threshold in\r\n - Alert's flyout\r\n - Alert's table\r\n - Alert details page (summary and chart)\r\n - Action generated by this alert","sha":"d13f884ec3a4e61fcc23e5594741ec436fa4c4fb"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #156255
Fixes #158204
Partially reverts #154801
RFC Document
Summary
This PR changes kibana.alert.evaluation.threshold unit to microseconds in AAD.
🧪 How to test