Repository navigation
[APM] Don't use service tx metrics on transaction detail page - #159085
Conversation
|
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
|
... I still think we should do a follow-up to this with an e2e test. This is not the first time this bug is introduced. I'd like it to be the last 🤞 |
|
@sqren agreed, keeping it in draft until I figure out a way to add some kind of test. Just worried about having to parse SVG or canvas 🥲 |
Yeah, I also briefly looked into it. There are no DOM elements to target (obviously) and I can't find a way to enable canvas inspection in Chrome (was that feature removed recently?). Firefox doesn't have canvas inspection afaict. |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
@sqren I've added some E2E tests in , mind having another look? |
sorenlouv
left a comment
There was a problem hiding this comment.
Thanks for adding an e2e test. Intercepting APIs feel a little fragile in the sense that tests will fail if an API is renamed - even if the UI stays unchanged.
|
@sqren agreed, but in this case if they're renamed we'll have a type check failure. Which at least is something. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…159085) (#159281) # Backport This will backport the following commits from `main` to `8.8`: - [[APM] Don't use service tx metrics on transaction detail page (#159085)](#159085) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2023-06-08T07:20:13Z","message":"[APM] Don't use service tx metrics on transaction detail page (#159085)","sha":"74102e592f5193e9566b16d921931c2dc2a67a86","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","v8.9.0","v8.8.2"],"number":159085,"url":"https://github.com/elastic/kibana/pull/159085","mergeCommit":{"message":"[APM] Don't use service tx metrics on transaction detail page (#159085)","sha":"74102e592f5193e9566b16d921931c2dc2a67a86"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159085","number":159085,"mergeCommit":{"message":"[APM] Don't use service tx metrics on transaction detail page (#159085)","sha":"74102e592f5193e9566b16d921931c2dc2a67a86"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
|
This PR backport didn't make it into the latest BC for 8.8.1. Updating the labels. |
Closes #158964.