Skip to content

[8.8] Fix global search crash on missing tag (#159196) - #159379

Merged
kibanamachine merged 1 commit into
elastic:8.8from
kibanamachine:backport/8.8/pr-159196
Jun 9, 2023
Merged

kibanamachine merged 1 commit into
elastic:8.8from
kibanamachine:backport/8.8/pr-159196

Conversation

@kibanamachine

Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

## Summary

Close elastic#157682,
elastic#159152

Fixes global search component crashing on the missing tag. Ideally this
should never happen as data is inconsistent, but we also shouldn't just
crash the component.

Adds a console warning in case hitting this edge case.

(cherry picked from commit aa4a5e5)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jun 9, 2023
@kibanamachine
kibanamachine enabled auto-merge (squash) June 9, 2023 10:33
@kibana-ci

Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
globalSearchBar 20.6KB 20.8KB +217.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
globalSearchBar 1 2 +1
securitySolution 400 404 +4
total +7

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
globalSearchBar 1 2 +1
securitySolution 480 484 +4
total +7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant

@kibanamachine
kibanamachine merged commit 7bf0394 into elastic:8.8 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants