Repository navigation
[AO] Handle buildEsQuery error (such as leading wildcard) in status change - #159891
Merged
maryam-saeidi merged 1 commit intoJun 19, 2023
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
marked this pull request as ready for review
June 19, 2023 08:35
Contributor
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 19, 2023
…hange (elastic#159891) Fixes elastic#159079 ## Summary In the case of providing a wildcard in the search query, an error might be generated depending on whether the related setting is enabled or not. This PR tries to handle this error on the Alerts page for a better user experience. |Before|After| |---|---| ||| (cherry picked from commit 229e8ca)
kibanamachine
added a commit
that referenced
this pull request
Jun 19, 2023
…atus change (#159891) (#159938) # Backport This will backport the following commits from `main` to `8.8`: - [AO] Handle buildEsQuery error (such as leading wildcard) in status change (#159891) (229e8ca) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T14:22:28Z","message":"[AO] Handle buildEsQuery error (such as leading wildcard) in status change (#159891)\n\nFixes #159079\r\n\r\n## Summary\r\n\r\nIn the case of providing a wildcard in the search query, an error might\r\nbe generated depending on whether the related setting is enabled or not.\r\nThis PR tries to handle this error on the Alerts page for a better user\r\nexperience.\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|||","sha":"229e8ca808b5aca07ad7cead3b64a5d63cd9c650"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159079
Summary
In the case of providing a wildcard in the search query, an error might be generated depending on whether the related setting is enabled or not. This PR tries to handle this error on the Alerts page for a better user experience.