Repository navigation
[Management] Prevent react warnings in index pattern creation - #16520
Merged
Merged
Conversation
Contributor
💚 Build Succeeded |
jen-huang
reviewed
Feb 6, 2018
| esService, | ||
| goToNextStep, | ||
| ) { | ||
| const node = document.getElementById(domElementId); |
Contributor
There was a problem hiding this comment.
Maybe make this into a function so both places can use it without repeating code?
Contributor
Author
|
@jen-huang Ready for another pass! |
Contributor
💚 Build Succeeded |
bmcconaghy
approved these changes
Feb 8, 2018
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16304
Checks for node existence before attempting to mount or unmount.
This will only go into 6.2, as #16129 adds this fix to 6.3 and beyond. That PR didn't go into 6.1 as it's not just a bug fix.