Skip to content

[Index Management] Update breadcrumbs - #165894

Merged
yuliacech merged 14 commits into
elastic:mainfrom
yuliacech:im/details_page/breadcrumbs
Sep 21, 2023
Merged

[Index Management] Update breadcrumbs #165894
yuliacech merged 14 commits into
elastic:mainfrom
yuliacech:im/details_page/breadcrumbs

Conversation

@yuliacech

@yuliacech yuliacech commented Sep 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Fixes #165844
Partially addresses #122577

This PR fixes the inconsistency with breadcrumbs in Index Management. Previously, the breadcrumbs were updated only when an index template or a component template was being created/edited. This PR adds breadcrumbs for each of 4 main tabs: indices, data streams, index templates, component templates. It also adds breadcrumbs for the new index details page.

Note for reviewers: Tabs "Documents" and "Pipelines" on the new index details page will not be implemented for now, so there are no breadcrumbs for them.

Note for copy review: This PR can be reviewed only in terms on breadcrumbs in Index Management. The copy review for the new index details page can be done in this PR.

Screenshots

Indices list

Breadcrumbs "Indices"

Screenshot 2023-09-07 at 17 22 56

Index details - overview tab

Breadcrumbs "Indices" (link) => "Index details" -> "Overview"
Screenshot 2023-09-08 at 17 20 45

Index details - mappings tab

Breadcrumbs "Indices"(link) -> "Index details" -> "Mappings"
Screenshot 2023-09-07 at 17 23 53

Index details - settings tab

Breadcrumbs "Indices"(link) -> "Index details" -> "Settings"
Screenshot 2023-09-07 at 17 24 00

Index details - stats tab

Breadcrumbs "Indices"(link) -> "Index details" -> "Stats"
Screenshot 2023-09-07 at 17 24 12

Data streams

Breadcrumbs "Data streams"
Screenshot 2023-09-07 at 17 23 03

Index templates

Breadcrumbs "Templates"
Screenshot 2023-09-07 at 17 23 10

Component templates

Breadcrumbs "Component templates"
Screenshot 2023-09-07 at 17 23 28

Checklist

@yuliacech yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.11.0 labels Sep 6, 2023
@yuliacech
yuliacech force-pushed the im/details_page/breadcrumbs branch from 75c1ae3 to 25b877f Compare September 7, 2023 15:14
@yuliacech
yuliacech marked this pull request as ready for review September 8, 2023 15:36
@yuliacech
yuliacech requested a review from a team as a code owner September 8, 2023 15:36
@elasticmachine

elasticmachine commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech added ui-copy Review of UI copy with docs team is recommended release_note:skip Skip the PR/issue when compiling release notes labels Sep 8, 2023
alisonelizabeth
alisonelizabeth reviewed Sep 8, 2023
View reviewed changes

@alisonelizabeth alisonelizabeth left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @yuliacech! It looks like the breadcrumb to clone a component template isn't correct, although the heading also says "Create..." 🤔 Would you mind taking a look? Otherwise, everything LGTM.

Screenshot 2023-09-08 at 2 54 57 PM

@alisonelizabeth alisonelizabeth mentioned this pull request Sep 13, 2023
Merged
@yuliacech

yuliacech commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Thanks a lot for the review, @alisonelizabeth!
Fixed the breadcrumbs for cloning a component template in 33d406b

Screenshot 2023-09-18 at 15 34 58

alisonelizabeth
alisonelizabeth approved these changes Sep 18, 2023
View reviewed changes

@alisonelizabeth alisonelizabeth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Did not test the latest locally, but code changes and screenshot LGTM.

@yuliacech

yuliacech commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

Hey @gchaps, could you please have a look at this PR? We are fixing the breadcrumbs in Index Management and it would be great to have them reviewed.

@yuliacech
yuliacech requested a review from gchaps September 19, 2023 13:18
@kibana-ci

kibana-ci commented Sep 21, 2023

Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / serverless common UI Index Management Indices "before all" hook for "renders the indices tab"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 605 604 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 598.7KB 601.1KB +2.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech

yuliacech commented Sep 21, 2023

Copy link
Copy Markdown
Contributor Author

I suggest to merge this PR for now and review the copy in the PR to enable the details page by default.

@yuliacech
yuliacech merged commit 969bbb0 into elastic:main Sep 21, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 21, 2023
@yuliacech yuliacech mentioned this pull request Sep 25, 2023
Closed
@yuliacech
yuliacech deleted the im/details_page/breadcrumbs branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes
@gchaps gchaps Awaiting requested review from gchaps

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// ui-copy Review of UI copy with docs team is recommended v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Index Management] Update breadcrumbs on the main page

5 participants

@yuliacech @elasticmachine @kibana-ci @alisonelizabeth @kibanamachine