Repository navigation
[Fleet] Show snapshot version in agent upgrade modal + allow custom values (but not in serverless) - #165978
Merged
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
Author
|
@criamico I added you as a reviewer as you seem to have written a lot of this code |
criamico
approved these changes
Sep 7, 2023
| }); | ||
| }); | ||
|
|
||
| it('should not strip -SNAPSHOT from kibana version', async () => { |
Member
There was a problem hiding this comment.
Could you just specify that this happens when not in serverless? it's going to be easier for future changes.
Contributor
|
@hop-dev looking at the logs, I don't the tests errors are related though: @afharo do you know who can help us fix the credentials? |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
thomheymann
approved these changes
Sep 8, 2023
thomheymann
left a comment
Contributor
There was a problem hiding this comment.
security changes LGTM
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 task done
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
hop-dev
added a commit
to hop-dev/kibana
that referenced
this pull request
Sep 12, 2023
…alues (but not in serverless) (elastic#165978) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2384280) # Conflicts: # x-pack/plugins/fleet/cypress/tasks/integrations.ts
hop-dev
added a commit
that referenced
this pull request
Sep 13, 2023
…ustom values (but not in serverless) (#165978) (#166255) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet] Show snapshot version in agent upgrade modal + allow custom values (but not in serverless) (#165978)](#165978) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"mark.hopkin@elastic.co"},"sourceCommit":{"committedDate":"2023-09-11T10:56:39Z","message":"[Fleet] Show snapshot version in agent upgrade modal + allow custom values (but not in serverless) (#165978)\n\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"238428076cd07994d843f798d51238fbdbc2cf53","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.11.0"],"number":165978,"url":"https://github.com/elastic/kibana/pull/165978","mergeCommit":{"message":"[Fleet] Show snapshot version in agent upgrade modal + allow custom values (but not in serverless) (#165978)\n\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"238428076cd07994d843f798d51238fbdbc2cf53"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165978","number":165978,"mergeCommit":{"message":"[Fleet] Show snapshot version in agent upgrade modal + allow custom values (but not in serverless) (#165978)\n\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"238428076cd07994d843f798d51238fbdbc2cf53"}}]}] BACKPORT-->
This was referenced Oct 1, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #139174
Snapshot kibana default version now includes snapshot
Serverless (custom option not allowed)
Non-serverless (custom option allowed)
