Skip to content

[8.10] [Fleet] Fix bulk action dropdown (#166475) - #167368

Merged
jillguyonnet merged 2 commits into
elastic:8.10from
jillguyonnet:backport/8.10/pr-166475
Sep 27, 2023
Merged

jillguyonnet merged 2 commits into
elastic:8.10from
jillguyonnet:backport/8.10/pr-166475

Conversation

@jillguyonnet

Copy link
Copy Markdown
Member

Backport

This will backport the following commits from main to 8.10:

Questions ?

Please refer to the Backport tool documentation

Closes elastic#164083
Related to elastic/sdh-beats#3759
Related to elastic#157844

This PR addresses two current issues affecting agent selection in Fleet
UI:
1. When there are inactive agents that are not listed on the current
page and "Select everything on all pages" is clicked, the count of
actionable agents is incorrect (cf. [this
comment](elastic#164083 (comment))
for details). This can have two consequences:
1. Incorrect and sometimes negative agent count in the "Actions"
dropdown.
   2. Disabled menu items in the "Actions" dropdown.
2. The "Select everything on all pages button is incorrectly displayed
when there are agents on managed policies on the page and there is no
pagination (cf. [this
comment](elastic#164083 (comment))).

(cherry picked from commit 591df70)

# Conflicts:
#	x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/bulk_actions.test.tsx
@jillguyonnet jillguyonnet added the backport This PR is a backport of another PR label Sep 27, 2023
@jillguyonnet
jillguyonnet enabled auto-merge (squash) September 27, 2023 07:51
@botelastic botelastic Bot added the Team:Fleet - DEPRECATED Use Team:streams-ui label Sep 27, 2023
@jillguyonnet jillguyonnet mentioned this pull request Sep 27, 2023
1 of 5 tasks
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ghost

ghost commented Sep 27, 2023

Copy link
Copy Markdown

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci

Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.0MB 1.0MB +425.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jillguyonnet
jillguyonnet merged commit 6e1ef68 into elastic:8.10 Sep 27, 2023
@jillguyonnet
jillguyonnet deleted the backport/8.10/pr-166475 branch September 27, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Fleet - DEPRECATED Use Team:streams-ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants