Repository navigation
[Synthetics] Private location public API's - #169376
Merged
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
force-pushed
the
private-locations-api
branch
from
October 19, 2023 12:44
cce693e to
6347e8b
Compare
shahzad31
force-pushed
the
private-locations-api
branch
from
October 23, 2023 14:57
584d9f1 to
fbccc52
Compare
shahzad31
marked this pull request as ready for review
October 23, 2023 15:00
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
…-locations-api
…kibana into private-locations-api
…asciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…asciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…asciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…asciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…asciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…asciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…asciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…ciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…ciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…kibana into private-locations-api
…ciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…ciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…ciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…ciidoc Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…ions/get_private_locations.ts Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
…kibana into private-locations-api
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
justinkambic
approved these changes
Nov 6, 2023
justinkambic
left a comment
Contributor
There was a problem hiding this comment.
I had a couple of nit copy improvements.
I did test the API as well, results:
POST
GET
DELETE
…asciidoc Co-authored-by: Justin Kambic <jk@elastic.co>
…asciidoc Co-authored-by: Justin Kambic <jk@elastic.co>
…ciidoc Co-authored-by: Justin Kambic <jk@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #169547
Private location API's
Added docs for creating/deleting private location APIs