Repository navigation
add timefilter to search source instead of inheriting from root search source - #16159
Merged
Merged
Conversation
…oot search source
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 19, 2018
…oot search source (elastic#16159)
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…oot search source (elastic#16159)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15852 added
use time filteroption to input controls.The implementation is incorrect in PR 15852. It adds the timefilter by allowing the search source to inherit from the root search source. This introduced a bug in that the root search source also included
pinnedfilters and the intent of the feature is only filter by time and not by pinned filters.This PR fixes the implementation to avoid inheriting from root search source and instead just add the time filter directly to the search source.