Repository navigation
Conversation
…t-embeddable-detail-view
…e-detail-view' into ml-161248-change-point-embeddable-detail-view
…e-detail-view' into ml-161248-change-point-embeddable-detail-view
…t-embeddable-detail-view
Member
|
Would be good to have a message what's the allowed range (e.g. between 1 and 50) for the max series of change point charts. Right now it's unclear what will give warning and what does not. Should the Screen.Recording.2023-08-07.at.11.46.44.mov |
peteharverson
left a comment
Contributor
There was a problem hiding this comment.
Gave this another test and apart from the disabling of the 'Attach' button when the number of series entered is invalid, all looks good.
Contributor
Author
thanks for reviewing @peteharverson! Max series validation was added in 002e192 |
Contributor
Author
|
@elasticmachine merge upstream |
peteharverson
approved these changes
Aug 8, 2023
peteharverson
left a comment
Contributor
There was a problem hiding this comment.
Other than one minor typo, latest changes LGTM
…t-embeddable-detail-view # Conflicts: # x-pack/plugins/ml/kibana.jsonc # x-pack/plugins/ml/public/application/app.tsx # x-pack/plugins/ml/public/application/contexts/kibana/kibana_context.ts # x-pack/plugins/ml/public/plugin.ts
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @darnautov |
js-jankisalvi
approved these changes
Aug 8, 2023
js-jankisalvi
left a comment
Contributor
There was a problem hiding this comment.
Verified locally:
- Add to case actions with different Cases privileges
- comment stored as persistablestate
Works as expected 👍
qn895
approved these changes
Aug 8, 2023
Member
|
LGTM 🎉 |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
…2796) ## Summary Part of elastic#161248 - Adds Change point charts as an embeddable component - Allows attachment of selected partitions to a new / existing dashboard  - Allows attachment of top N change points (with an ascending sorting by `p_value`)  - Allows applying a persistent time range - Attachment to a case of a single change point / selected partitions and applied time range  - Exposes `EmbeddableChangePointChart` embeddable component as part of the plugin start contract ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #161248
p_value)EmbeddableChangePointChartembeddable component as part of the plugin start contractChecklist
Delete any items that are not applicable to this PR.